Re: [PATCH 8/8] fusion - mptctl -adding asyn event notification support

[Christoph Hellwig <hch@infradead.org>]

On Thu, Feb 02, 2006 at 05:20:01PM -0700, Moore, Eric wrote:
> Adding aen support.

looks good, but it could use some codingstyle love:


+/*
+ * Event Handler function
+ */
+static int mptctl_event_process(MPT_ADAPTER *ioc, EventNotificationReply_t *pEvReply);

no need for the forward prototype, the function isn't used before it's
defined.

+struct fasync_struct *async_queue=NULL;

no need to initialize this to NULL because it'll go into .bss and will
be initializes automatically.  Also this variable can be static.

 /*=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/
+/* ASYNC Event Notification Support */
+static int
+mptctl_event_process(MPT_ADAPTER *ioc, EventNotificationReply_t *pEvReply)
+{
+	u8 event;
+
+	event = le32_to_cpu(pEvReply->Event) & 0xFF;
+
+	dctlprintk(("%s() called\n", __FUNCTION__));
+	if(async_queue == NULL)

	if (async_queue == NULL)

or even better

	if (!async_queue)

+		ioc->aen_event_read_flag=1;

and please always put spaces around the '='

+static int
+mptctl_fasync(int fd, struct file *filep, int mode)
+{
+	MPT_ADAPTER	*ioc;
+
+	list_for_each_entry(ioc, &ioc_list, list)
+		ioc->aen_event_read_flag=0;

doesn't this need some locking?