From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Ulrich Drepper <drepper@redhat.com>,
linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: One more unlock missing in error case
Date: Sun, 5 Feb 2006 02:46:09 +0100 [thread overview]
Message-ID: <20060205014609.GA5271@stusta.de> (raw)
In-Reply-To: <20060204160830.1a9810a2.akpm@osdl.org>
On Sat, Feb 04, 2006 at 04:08:30PM -0800, Andrew Morton wrote:
> Ulrich Drepper <drepper@redhat.com> wrote:
> >
> > This patch is needed to in addition to the other unlocking fix which is
> > already applied. It should be obvious that the system will deadlock in
> > case this isn't done.
>
> hmm. How's about we undo that goto tangle while we're there?
>...
The fput_unlock_fail label change looks good, but IMHO moving of retval
settings out of the if's makes the code less readable.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
prev parent reply other threads:[~2006-02-05 1:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-04 17:23 One more unlock missing in error case Ulrich Drepper
2006-02-05 0:08 ` Andrew Morton
2006-02-05 0:49 ` Ulrich Drepper
2006-02-05 1:46 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060205014609.GA5271@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=drepper@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.