From: Andi Kleen <ak@suse.de>
To: torvalds@osdl.org
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, jbeulich@novell.com,
Ingo Molnar <mingo@elte.hu>
Subject: [PATCH for 2.6.16] Fix bad apic fix on i386
Date: Tue, 7 Feb 2006 12:48:00 +0100 [thread overview]
Message-ID: <200602071248.01244.ak@suse.de> (raw)
Fix wrong ! in bad apic fix
I forget to remove the ! when moving the code from x86-64 to i386
x86-64 tested !disable_apic, but of course for cpu_has_apic
it shouldn't be negated.
Credit goes to Jan Beulich for spotting it with eagle eyes.
Cc: jbeulich@novell
Cc: mingo@elte.hu
Signed-off-by: Andi Kleen <ak@suse.de>
Index: linux/arch/i386/kernel/apic.c
===================================================================
--- linux.orig/arch/i386/kernel/apic.c
+++ linux/arch/i386/kernel/apic.c
@@ -77,7 +77,7 @@ void ack_bad_irq(unsigned int irq)
* completely.
* But only ack when the APIC is enabled -AK
*/
- if (!cpu_has_apic)
+ if (cpu_has_apic)
ack_APIC_irq();
}
reply other threads:[~2006-02-07 11:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602071248.01244.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.