* [PATCH for 2.6.16] Fix bad apic fix on i386
@ 2006-02-07 11:48 Andi Kleen
0 siblings, 0 replies; only message in thread
From: Andi Kleen @ 2006-02-07 11:48 UTC (permalink / raw)
To: torvalds; +Cc: akpm, linux-kernel, jbeulich, Ingo Molnar
Fix wrong ! in bad apic fix
I forget to remove the ! when moving the code from x86-64 to i386
x86-64 tested !disable_apic, but of course for cpu_has_apic
it shouldn't be negated.
Credit goes to Jan Beulich for spotting it with eagle eyes.
Cc: jbeulich@novell
Cc: mingo@elte.hu
Signed-off-by: Andi Kleen <ak@suse.de>
Index: linux/arch/i386/kernel/apic.c
===================================================================
--- linux.orig/arch/i386/kernel/apic.c
+++ linux/arch/i386/kernel/apic.c
@@ -77,7 +77,7 @@ void ack_bad_irq(unsigned int irq)
* completely.
* But only ack when the APIC is enabled -AK
*/
- if (!cpu_has_apic)
+ if (cpu_has_apic)
ack_APIC_irq();
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-02-07 11:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-07 11:48 [PATCH for 2.6.16] Fix bad apic fix on i386 Andi Kleen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.