[PATCH] Fix compile error in 8250_au1x00.c

[PATCH] Fix compile error in 8250_au1x00.c

[Jordan Crouse]

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

This patch fixes a compile error when building the 8250_au1x00 driver
for the DB1550, which doesn't have a UART2 defined, resulting in a 
compile error.

There are additional rumors of strangeness on the DB1550, but those
are unsubstantiated at this point.  At least with this patch, it will
compile.

Jordan
-- 
Jordan Crouse
Senior Linux Engineer
AMD - Personal Connectivity Solutions Group
<www.amd.com/embeddedprocessors>

[-- Attachment #2: 8250_fixup.patch --]
[-- Type: text/plain, Size: 751 bytes --]

[PATCH]:  Fixup for the AU1X00 8250 driver

The DB1550 actually doesn't have a UART2.  Remove it from the list.

Signed-off-by: Jordan Crouse <jordan.crouse@amd.com>
---

 drivers/serial/8250_au1x00.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/serial/8250_au1x00.c b/drivers/serial/8250_au1x00.c
index 06ae8fb..8d8d7a7 100644
--- a/drivers/serial/8250_au1x00.c
+++ b/drivers/serial/8250_au1x00.c
@@ -56,7 +56,6 @@ static struct plat_serial8250_port au1x0
 #elif defined(CONFIG_SOC_AU1550)
 	PORT(UART0_ADDR, AU1550_UART0_INT),
 	PORT(UART1_ADDR, AU1550_UART1_INT),
-	PORT(UART2_ADDR, AU1550_UART2_INT),
 	PORT(UART3_ADDR, AU1550_UART3_INT),
 #elif defined(CONFIG_SOC_AU1200)
 	PORT(UART0_ADDR, AU1200_UART0_INT),

Re: [PATCH] Fix compile error in 8250_au1x00.c

[Russell King]

On Tue, Feb 07, 2006 at 02:15:00PM -0700, Jordan Crouse wrote:
> The DB1550 actually doesn't have a UART2.  Remove it from the list.

Applied, thanks.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core

Re: [PATCH] Fix compile error in 8250_au1x00.c

[Jon Anders Haugum]

On Tue, 7 Feb 2006, Jordan Crouse wrote:

> There are additional rumors of strangeness on the DB1550, but those
> are unsubstantiated at this point.  At least with this patch, it will
> compile.

I can confirm strangeness on Au1550, and I've pinned it down to wrong 
way of setting the divisor register. The alchemy uart have got a spearate 
register for divisor, while the driver tries to set the divisor latch 
just like on any 16550 uart.

How would be a good way of solving this? I can imagine a couple of ways:

1. Make divisor latch read/write a bit more abstract, so that a 
alternative function can be used for alchemy.

2. Add divisor latch to the alchemy uart register map. But since the 
divisor register is located in a single 32-bit register and the driver 
will try to access it one byte at a time; byte access would be needed. And 
this would add some endian handling...


-- 
Jon Anders Haugum