From: "Juha Yrjölä" <juha.yrjola@nokia.com>
To: ext Dirk Behme <dirk.behme@googlemail.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] Convert drivers to new irq trigger modes
Date: Wed, 8 Feb 2006 07:14:51 +0200 [thread overview]
Message-ID: <20060208051451.GA22845@two.research.nokia.com> (raw)
In-Reply-To: <43E8D9CA.8000204@gmail.com>
Hi Dirk,
On Tue, Feb 07, 2006 at 06:32:58PM +0100, ext Dirk Behme wrote:
> int irq;
> + int irq_type;
This doesn't seem to be used anywhere.
> + isp->irq_type = SA_SAMPLE_RANDOM;
> isp->client.addr = address;
> i2c_set_clientdata(&isp->client, isp);
> isp->client.adapter = bus;
> @@ -1602,7 +1604,7 @@ fail1:
> isp->irq = OMAP_GPIO_IRQ(2);
> omap_request_gpio(2);
> omap_set_gpio_direction(2, 1);
> - set_irq_type(isp->irq, IRQT_FALLING);
> + isp->irq_type = SA_TRIGGER_FALLING;
You should be ORring here. Otherwise you lose the SA_SAMPLE_RANDOM flag.
Cheers,
Juha
next prev parent reply other threads:[~2006-02-08 5:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-07 17:32 [PATCH] Convert drivers to new irq trigger modes Dirk Behme
2006-02-07 23:16 ` Tony Lindgren
2006-02-08 5:14 ` Juha Yrjölä [this message]
2006-02-08 19:10 ` Dirk Behme
2006-02-09 6:25 ` Juha Yrjölä
2006-02-12 15:43 ` Dirk Behme
2006-02-13 9:17 ` Juha Yrjölä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060208051451.GA22845@two.research.nokia.com \
--to=juha.yrjola@nokia.com \
--cc=dirk.behme@googlemail.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.