From: Glauber de Oliveira Costa <glommer@br.ibm.com>
To: Selinux@tycho.nsa.gov
Subject: [PATCH] add version option to newrole
Date: Wed, 8 Feb 2006 09:34:33 -0200 [thread overview]
Message-ID: <200602080934.33613.glommer@br.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 412 bytes --]
When trying to isolate a problem today, I missed a lot an version option (-v
or such). This simple patch adds such an option.
If it's of interest, such an option may be added to whole policycoreutils
package. (IMHO, it would be useful). With this possibility in mind, I decided
to implement the version string in a separate version.h file, that could be
included by other packages too.
Patch follows.
[-- Attachment #2: patch-newrole --]
[-- Type: text/x-diff, Size: 2030 bytes --]
diff -upNr policycoreutils-1.29.18/newrole/newrole.c policycoreutils-1.29.18.mine/newrole/newrole.c
--- policycoreutils-1.29.18/newrole/newrole.c 2006-02-02 15:08:13.000000000 -0200
+++ policycoreutils-1.29.18.mine/newrole/newrole.c 2006-02-07 16:16:23.000000000 -0200
@@ -10,7 +10,7 @@
*
* USAGE:
*
- * newrole [ -r role ] [ -t type ] [ -l level ] [ -- args ]
+ * newrole [ -r role ] [ -t type ] [ -l level ] [ -v ] [ -- args ]
*
* BUILD OPTIONS:
*
@@ -82,9 +82,10 @@
#ifndef PACKAGE
#define PACKAGE "policycoreutils" /* the name of this package lang translation */
#endif
+#include "version.h"
/* USAGE_STRING describes the command-line args of this program. */
-#define USAGE_STRING "USAGE: newrole [ -r role ] [ -t type ] [ -l level ] [ -- args ]"
+#define USAGE_STRING "USAGE: newrole [ -r role ] [ -t type ] [ -l level ] [ -v ] [ -- args ]"
#define DEFAULT_CONTEXT_SIZE 255 /* first guess at context size */
@@ -417,6 +418,7 @@ int main( int argc, char *argv[] ) {
{ "role", 1, 0, 'r' },
{ "type", 1, 0, 't' },
{ "level", 1, 0, 'l' },
+ { "version", 0, 0, 'v' },
{ NULL, 0, 0, 0 }
};
char *role_s = NULL; /* role spec'd by user in argv[] */
@@ -465,11 +467,15 @@ int main( int argc, char *argv[] ) {
}
while (1) {
- clflag=getopt_long(argc,argv,"r:t:l:",long_options,&flag_index);
+ clflag=getopt_long(argc,argv,"r:t:l:v",long_options,&flag_index);
if (clflag == -1)
break;
switch( clflag ) {
+ case 'v':
+ printf("newrole version %s\n",VERSION);
+ exit(0);
+ break;
case 'r':
/* If role_s is already set, the user spec'd multiple roles - bad. */
if( role_s ) {
diff -upNr policycoreutils-1.29.18/newrole/version.h policycoreutils-1.29.18.mine/newrole/version.h
--- policycoreutils-1.29.18/newrole/version.h 1969-12-31 21:00:00.000000000 -0300
+++ policycoreutils-1.29.18.mine/newrole/version.h 2006-02-07 16:15:47.000000000 -0200
@@ -0,0 +1,4 @@
+
+#ifndef VERSION
+#define VERSION "1.29.18"
+#endif
next reply other threads:[~2006-02-08 11:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-08 11:34 Glauber de Oliveira Costa [this message]
2006-02-08 12:43 ` [PATCH] add version option to newrole Stephen Smalley
2006-02-08 13:25 ` Glauber de Oliveira Costa
2006-02-08 13:06 ` Steve G
2006-02-08 13:32 ` Glauber de Oliveira Costa
-- strict thread matches above, loose matches on Subject: below --
2006-02-08 16:45 [PATCH] Add " Glauber de Oliveira Costa
2006-02-08 16:54 ` Stephen Smalley
2006-02-08 17:10 ` Steve G
2006-02-08 17:16 ` Glauber de Oliveira Costa
2006-02-09 20:09 ` Stephen Smalley
2006-02-09 20:12 ` Stephen Smalley
2006-02-10 13:51 ` Glauber de Oliveira Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602080934.33613.glommer@br.ibm.com \
--to=glommer@br.ibm.com \
--cc=Selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.