From: Pete Zaitcev <zaitcev@redhat.com>
To: Marc Koschewski <marc@osknowledge.org>
Cc: zaitcev@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH GIT] drivers/block/ub.c - misc. cleanup/indentation, removed unneeded return
Date: Wed, 8 Feb 2006 19:40:57 -0800 [thread overview]
Message-ID: <20060208194057.55b02719.zaitcev@redhat.com> (raw)
In-Reply-To: <mailman.1139418724.17734.linux-kernel2news@redhat.com>
On Wed, 8 Feb 2006 10:29:15 +0100, Marc Koschewski <marc@osknowledge.org> wrote:
> I created this little patch while reading through drivers/block/ub.c. It fixes
> some indentation/whitespace as well as some empty commenting, an hardcoded
> module name and an unneeded return.
I strongly disagree.
The only segment which has some merit is the one which replaces the .name
with DRV_NAME. It could have been "usb-block" or something, but we probably
won't be using that, so it's all right.
But the rest is quite bad, the worst being indenting the switch statement.
Is there nothing else you can do in the whole kernel?
-- Pete
next parent reply other threads:[~2006-02-09 3:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.1139418724.17734.linux-kernel2news@redhat.com>
2006-02-09 3:40 ` Pete Zaitcev [this message]
2006-02-09 9:21 ` [PATCH GIT] drivers/block/ub.c - misc. cleanup/indentation, removed unneeded return Marc Koschewski
2006-02-09 16:55 ` Pete Zaitcev
2006-02-09 17:25 ` Marc Koschewski
2006-02-09 17:24 ` Jan Engelhardt
2006-02-09 18:24 ` Pete Zaitcev
2006-02-08 9:29 Marc Koschewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060208194057.55b02719.zaitcev@redhat.com \
--to=zaitcev@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc@osknowledge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.