All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Ulrich Drepper <drepper@redhat.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: [PATCH] fstatat64 support
Date: Wed, 8 Feb 2006 20:40:15 +0000	[thread overview]
Message-ID: <20060208204015.GA25477@infradead.org> (raw)
In-Reply-To: <200602082008.k18K8dqE026598@devserv.devel.redhat.com>

On Wed, Feb 08, 2006 at 03:08:39PM -0500, Ulrich Drepper wrote:
> The *at patches introduced fstatat and, due to inusfficient research, I
> used the newfstat functions generally as the guideline.  The result is
> that on 32-bit platforms we don't have all the information needed to
> implement fstatat64.
> 
> This patch modifies the code to pass up 64-bit information if
> __ARCH_WANT_STAT64 is defined.  I renamed the syscall entry point to
> make this clear.  Other archs will continue to use the existing code.
> On x86-64 the compat code is implemented using a new sys32_ function.
> this is what is done for the other stat syscalls as well.
> 
> 
> This patch might break some other archs (those which define
> __ARCH_WANT_STAT64 and which already wired up the syscall).  Yet
> others might need changes to accomodate the compatibility mode.
> I really don't want to do that work because all this stat handling
> is a mess (more so in glibc, but the kernel is also affected).  It
> should be done by the arch maintainers.  I'll provide some
> stand-alone test shortly.  Those who are eager could compile glibc
> and run 'make check' (no installation needed).

please remove the new from the syscall name.  just sys_fstatat64


  reply	other threads:[~2006-02-08 20:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-08 20:08 [PATCH] fstatat64 support Ulrich Drepper
2006-02-08 20:40 ` Christoph Hellwig [this message]
2006-02-08 21:04   ` Ulrich Drepper
2006-02-10  4:43     ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060208204015.GA25477@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@osdl.org \
    --cc=drepper@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.