[kj][Patch] remove implicit sign bit on single bit

[kj][Patch] remove implicit sign bit on single bit

[Darren Jenkins\]

[-- Attachment #1: Type: text/plain, Size: 947 bytes --]

Hi,

This is my first patch so I hope I get everything right.

http://linuxicc.sourceforge.net/

Warnings/Error while compiling with Intel C Compiler

Says there is a Warning #108: implictly-signed bit field of length 1

in sound/oss/viacXXX_audio.c @ line number 310

looking at the code it seems like it is supposed to be a single bit
field used as a lock. This just makes it unsigned.

Signed-off-by: Darren Jenkins <darrenrjenkins@gmail.com>


--- linux-2.6.16-rc2/sound/oss/via82cxxx_audio.c.orig	2006-02-08
13:43:27.000000000 +1100
+++ linux-2.6.16-rc2/sound/oss/via82cxxx_audio.c	2006-02-08
13:45:39.000000000 +1100
@@ -306,9 +306,8 @@ struct via_info {
 	unsigned intmask: 1;	/* Needs int bits */
 	unsigned sixchannel: 1;	/* 8233/35 with 6 channel support */
 	unsigned volume: 1;
+	unsigned locked_rate : 1;
 
-	int locked_rate : 1;
-	
 	int mixer_vol;		/* 8233/35 volume  - not yet implemented */
 
 	struct semaphore syscall_sem;






[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [kj][Patch] remove implicit sign bit on single bit

[Nishanth Aravamudan]

[-- Attachment #1: Type: text/plain, Size: 869 bytes --]

On 08.02.2006 [15:17:27 +1100], Darren Jenkins" wrote:
> Hi,
> 
> This is my first patch so I hope I get everything right.

Two things.

> http://linuxicc.sourceforge.net/
> 
> Warnings/Error while compiling with Intel C Compiler
> 
> Says there is a Warning #108: implictly-signed bit field of length 1
> 
> in sound/oss/viacXXX_audio.c @ line number 310
> 
> looking at the code it seems like it is supposed to be a single bit
> field used as a lock. This just makes it unsigned.
> 
> Signed-off-by: Darren Jenkins <darrenrjenkins@gmail.com>
> 
> 
> --- linux-2.6.16-rc2/sound/oss/via82cxxx_audio.c.orig	2006-02-08
> 13:43:27.000000000 +1100
> +++ linux-2.6.16-rc2/sound/oss/via82cxxx_audio.c	2006-02-08
> 13:45:39.000000000 +1100

Looks like this part was line-wrapped, but the patch was not. Strange.

And OSS is deprecated. Don't bother patching it.

Thanks,
Nish

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [kj][Patch] remove implicit sign bit on single bit

[Randy.Dunlap]

[-- Attachment #1: Type: text/plain, Size: 1272 bytes --]

On Wed, 08 Feb 2006 15:17:27 +1100 Darren Jenkins\\ wrote:

> Hi,
> 
> This is my first patch so I hope I get everything right.
> 
> http://linuxicc.sourceforge.net/
> 
> Warnings/Error while compiling with Intel C Compiler
> 
> Says there is a Warning #108: implictly-signed bit field of length 1
> 
> in sound/oss/viacXXX_audio.c @ line number 310
> 
> looking at the code it seems like it is supposed to be a single bit
> field used as a lock. This just makes it unsigned.

BTW, sparse also complains about this one (and other problems in
general and "signed 1-bit fields" in many places):
sound/oss/via82cxxx_audio.c:310:21: error: dubious one-bit signed bitfield


> Signed-off-by: Darren Jenkins <darrenrjenkins@gmail.com>
> 
> 
> --- linux-2.6.16-rc2/sound/oss/via82cxxx_audio.c.orig	2006-02-08
> 13:43:27.000000000 +1100
> +++ linux-2.6.16-rc2/sound/oss/via82cxxx_audio.c	2006-02-08
> 13:45:39.000000000 +1100
> @@ -306,9 +306,8 @@ struct via_info {
>  	unsigned intmask: 1;	/* Needs int bits */
>  	unsigned sixchannel: 1;	/* 8233/35 with 6 channel support */
>  	unsigned volume: 1;
> +	unsigned locked_rate : 1;
>  
> -	int locked_rate : 1;
> -	
>  	int mixer_vol;		/* 8233/35 volume  - not yet implemented */
>  
>  	struct semaphore syscall_sem;


---
~Randy

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [kj][Patch] remove implicit sign bit on single bit

[Alexey Dobriyan]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

On Tue, Feb 07, 2006 at 08:39:10PM -0800, Nishanth Aravamudan wrote:
> And OSS is deprecated. Don't bother patching it.

Oh, come on! devfs is still not removed.


[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [kj][Patch] remove implicit sign bit on single bit

[Greg KH]

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

On Thu, Feb 09, 2006 at 01:52:52AM +0300, Alexey Dobriyan wrote:
> On Tue, Feb 07, 2006 at 08:39:10PM -0800, Nishanth Aravamudan wrote:
> > And OSS is deprecated. Don't bother patching it.
> 
> Oh, come on! devfs is still not removed.

Have you tried to use it lately?  You might find out that more of it is
gone than you expected... :)

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [kj][Patch] remove implicit sign bit on single bit

[Nishanth Aravamudan]

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

On 09.02.2006 [01:52:52 +0300], Alexey Dobriyan wrote:
> On Tue, Feb 07, 2006 at 08:39:10PM -0800, Nishanth Aravamudan wrote:
> > And OSS is deprecated. Don't bother patching it.
> 
> Oh, come on! devfs is still not removed.

Fair enough; but I believe time is better spent patching subsystems
which matter. My opinion, though, so if you're willing to push them
upstream, then they are fine (and I think Darren figured out the
line-wrapping).

Thanks,
Nish

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [kj][Patch] remove implicit sign bit on single bit

[Darren Jenkins\]

[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]

On Wed, 2006-02-08 at 23:15 -0800, Nishanth Aravamudan wrote:
> Fair enough; but I believe time is better spent patching subsystems
> which matter. My opinion, though, so if you're willing to push them
> upstream, then they are fine (and I think Darren figured out the
> line-wrapping).
> 
> Thanks,
> Nish

Well I'm not too bothered about it either way, but I figure that if
people are still building/using it why not apply the patch?
Anyway now I have figured out the line-wrapping I guess I had better do
a re-send.


Signed-off-by: Darren Jenkins <darrenrjenkins@gmail.com>

--- linux-2.6.16-rc2/sound/oss/via82cxxx_audio.c.orig	2006-02-08 13:43:27.000000000 +1100
+++ linux-2.6.16-rc2/sound/oss/via82cxxx_audio.c	2006-02-08 13:45:39.000000000 +1100
@@ -306,9 +306,8 @@ struct via_info {
 	unsigned intmask: 1;	/* Needs int bits */
 	unsigned sixchannel: 1;	/* 8233/35 with 6 channel support */
 	unsigned volume: 1;
+	unsigned locked_rate : 1;
 
-	int locked_rate : 1;
-	
 	int mixer_vol;		/* 8233/35 volume  - not yet implemented */
 
 	struct semaphore syscall_sem;



[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [kj][Patch] remove implicit sign bit on single bit

[Alexey Dobriyan]

[-- Attachment #1: Type: text/plain, Size: 576 bytes --]

On Thu, Feb 09, 2006 at 09:21:24PM +1100, Darren Jenkins" wrote:
> --- linux-2.6.16-rc2/sound/oss/via82cxxx_audio.c.orig
> +++ linux-2.6.16-rc2/sound/oss/via82cxxx_audio.c
> @@ -306,9 +306,8 @@ struct via_info {
>  	unsigned intmask: 1;	/* Needs int bits */
>  	unsigned sixchannel: 1;	/* 8233/35 with 6 channel support */
>  	unsigned volume: 1;
> +	unsigned locked_rate : 1;
>
> -	int locked_rate : 1;
> -
>  	int mixer_vol;		/* 8233/35 volume  - not yet implemented */
> 
>  	struct semaphore syscall_sem;

These patches are OK, except

	unsigned int a:1;

is preferred. 


[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors