From: Adrian Bunk <bunk@stusta.de>
To: Phillip Susi <psusi@cfl.rr.com>
Cc: linux-kernel@vger.kernel.org, Peter Osterlund <petero2@telia.com>
Subject: pktcdvd stack usage regression
Date: Thu, 9 Feb 2006 03:09:32 +0100 [thread overview]
Message-ID: <20060209020932.GY3524@stusta.de> (raw)
Hi Phillip,
your recent patch "pktcdvd: Allow larger packets" changed
PACKET_MAX_SIZE in the pktcdvd driver from 32 to 128.
Unfortunately, drivers/block/pktcdvd.c contains the following:
<-- snip -->
...
static void pkt_start_write(struct pktcdvd_device *pd, struct
packet_data *pkt)
{
struct bio *bio;
struct page *pages[PACKET_MAX_SIZE];
int offsets[PACKET_MAX_SIZE];
...
<-- snip -->
With PACKET_MAX_SIZE=128, this allocates more than 1 kB on the stack
which is not acceptable considering that we might have only 4 kB stack
altogether.
Please either fix this before 2.6.16 or ask Linus to revert commit
5c55ac9bbca22ee134408f83de5f2bda3b1b2a53.
TIA
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next reply other threads:[~2006-02-09 2:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-09 2:09 Adrian Bunk [this message]
2006-02-09 6:01 ` pktcdvd stack usage regression Peter Osterlund
2006-02-10 14:39 ` Adrian Bunk
2006-02-10 20:56 ` Peter Osterlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060209020932.GY3524@stusta.de \
--to=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=petero2@telia.com \
--cc=psusi@cfl.rr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.