From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>, Christoph Hellwig <hch@lst.de>
Cc: linux-kernel@vger.kernel.org, achim_leubner@adaptec.com,
linux-scsi@vger.kernel.org
Subject: [-mm patch] drivers/scsi/gdth.c: make __gdth_execute() static
Date: Fri, 10 Feb 2006 01:37:37 +0100 [thread overview]
Message-ID: <20060210003737.GH3524@stusta.de> (raw)
In-Reply-To: <20060207220627.345107c3.akpm@osdl.org>
On Tue, Feb 07, 2006 at 10:06:27PM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.16-rc1-mm5:
>...
> +gdth-add-execute-firmware-command-abstraction.patch
>
> scsi driver API modernisation
>...
I don't see any reason for __gdth_execute() being global.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/scsi/gdth.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--- linux-2.6.16-rc2-mm1-full/drivers/scsi/gdth.c.old 2006-02-10 00:49:53.000000000 +0100
+++ linux-2.6.16-rc2-mm1-full/drivers/scsi/gdth.c 2006-02-10 00:51:05.000000000 +0100
@@ -693,8 +693,8 @@
complete(scp->request->waiting);
}
-int __gdth_execute(struct scsi_device *sdev, gdth_cmd_str *gdtcmd, char *cmnd,
- int timeout, u32 *info)
+static int __gdth_execute(struct scsi_device *sdev, gdth_cmd_str *gdtcmd,
+ char *cmnd, int timeout, u32 *info)
{
struct scsi_request *scp = scsi_allocate_request(sdev, GFP_KERNEL);
unsigned bufflen = gdtcmd ? sizeof(gdth_cmd_str) : 0;
@@ -727,8 +727,8 @@
complete(scp->request.waiting);
}
-int __gdth_execute(struct scsi_device *sdev, gdth_cmd_str *gdtcmd, char *cmnd,
- int timeout, u32 *info)
+static int __gdth_execute(struct scsi_device *sdev, gdth_cmd_str *gdtcmd,
+ char *cmnd, int timeout, u32 *info)
{
Scsi_Cmnd *scp = scsi_allocate_device(sdev, 1, FALSE);
unsigned bufflen = gdtcmd ? sizeof(gdth_cmd_str) : 0;
next prev parent reply other threads:[~2006-02-10 0:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-08 6:06 2.6.16-rc2-mm1 Andrew Morton
2006-02-08 21:17 ` 2.6.16-rc2-mm1 Paul Jackson
2006-02-10 10:34 ` 2.6.16-rc2-mm1 Sachin Sant
2006-02-10 0:37 ` Adrian Bunk [this message]
2006-02-10 13:11 ` [-mm patch] drivers/scsi/gdth.c: make __gdth_execute() static Christoph Hellwig
2006-02-10 0:41 ` [-mm patch] drivers/message/fusion/mptctl.c: make struct async_queue static Adrian Bunk
2006-02-10 0:43 ` [-mm patch] drivers/video/geode/video_gx.c: make struct gx_pll_table_48MHz static Adrian Bunk
2006-02-10 12:31 ` [-mm patch] fs/xfs/linux-2.6/xfs_linux.h: #if CONFIG_SMP -> #ifdef CONFIG_SMP Adrian Bunk
2006-02-10 14:52 ` Radeonfb ignores video= parameter [was: Re: 2.6.16-rc2-mm1] Mattia Dongili
2006-02-10 15:14 ` [PATCH] fbdev: Fix typo in fbmem.c Antonino A. Daplas
2006-02-10 15:14 ` Antonino A. Daplas
2006-02-10 16:34 ` Mattia Dongili
2006-02-10 18:17 ` 2.6.16-rc2-mm1 Coywolf Qi Hunt
2006-02-10 19:25 ` 2.6.16-rc2-mm1 Andrew Morton
2006-02-10 20:05 ` 2.6.16-rc2-mm1 Coywolf Qi Hunt
2006-02-10 20:22 ` 2.6.16-rc2-mm1 Matthias Urlichs
2006-02-10 21:30 ` 2.6.16-rc2-mm1 Jim Crilly
2006-02-10 22:25 ` 2.6.16-rc2-mm1 Andrew Morton
2006-02-10 22:34 ` 2.6.16-rc2-mm1 Dave Jones
2006-02-10 22:28 ` 2.6.16-rc2-mm1 Jeff Garzik
2006-02-10 22:30 ` 2.6.16-rc2-mm1 Jim Crilly
2006-02-10 21:55 ` 2.6.16-rc2-mm1 Pavel Machek
2006-02-11 20:31 ` 2.6.16-rc2-mm1 Martin Hermanowski
2006-02-11 21:41 ` 2.6.16-rc2-mm1 Andrew Morton
2006-02-11 22:27 ` 2.6.16-rc2-mm1 Martin Hermanowski
2006-02-11 23:34 ` 2.6.16-rc2-mm1 Andrew Morton
2006-02-12 12:10 ` 2.6.16-rc2-mm1 Martin Hermanowski
2006-02-13 23:30 ` 2.6.16-rc2-mm1: crash on suspend Laurent Riffard
2006-02-14 0:57 ` 2.6.16-rc2-mm1 Alexandre Buisse
2006-02-14 0:51 ` 2.6.16-rc2-mm1 Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060210003737.GH3524@stusta.de \
--to=bunk@stusta.de \
--cc=achim_leubner@adaptec.com \
--cc=akpm@osdl.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.