All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: akpm@osdl.org
Cc: hugh@veritas.com, wli@holomorphy.com, nickpiggin@yahoo.com.au,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] compound page: use page[1].lru
Date: Sun, 12 Feb 2006 23:59:06 -0800 (PST)	[thread overview]
Message-ID: <20060212.235906.73211762.davem@davemloft.net> (raw)
In-Reply-To: <20060212231223.773d76ea.akpm@osdl.org>

From: Andrew Morton <akpm@osdl.org>
Date: Sun, 12 Feb 2006 23:12:23 -0800

> "David S. Miller" <davem@davemloft.net> wrote:
> >
> > The ->mapping check is there essentially to hit user mapped pages that
> > would be modified by the kernel using kernel space memory accesses
> > other than those done by copy_user_page() and clear_user_page() (and
> > their brothers copy_user_highpage() and clear_user_highpage() which
> > just call the former directly on a non-HIGHPAGE platform like
> > sparc64).
> 
> The direct-io.c code just does memset.  (That's very common - maybe
> clear_user_highpage_partial() is needed?)

Yes, something like clear_user_higpage_partial() is definitely needed
for cases like direct-io.c.

We have similar handling for when ptrace() uses get_user_pages() and
tries to write to those pages, via copy_to_user_page() and
copy_from_user_page().  But those interfaces don't clear memory and
they only work in the ptrace path, and they are optimized for that
usage.

      reply	other threads:[~2006-02-13  7:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-12 19:46 [PATCH 1/3] compound page: use page[1].lru Hugh Dickins
2006-02-12 19:47 ` [PATCH 2/3] compound page: default destructor Hugh Dickins
2006-02-12 19:50 ` [PATCH 3/3] compound page: no access_process_vm check Hugh Dickins
2006-02-12 21:54 ` [PATCH 1/3] compound page: use page[1].lru Andrew Morton
2006-02-13  0:57   ` Hugh Dickins
2006-02-13  2:13     ` Andrew Morton
2006-02-13  7:05       ` David S. Miller
2006-02-13  7:12         ` Andrew Morton
2006-02-13  7:59           ` David S. Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060212.235906.73211762.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=akpm@osdl.org \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickpiggin@yahoo.com.au \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.