From: Al Viro <viro@ftp.linux.org.uk>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH] sparc32: Fix div, udiv, mul, umul, rem, urem breakage
Date: Sun, 12 Feb 2006 00:21:14 +0000 [thread overview]
Message-ID: <20060212002114.GS27946@ftp.linux.org.uk> (raw)
In-Reply-To: <20060211113817.GA25564@palantir8>
On Sun, Feb 12, 2006 at 10:54:37AM +1100, Rusty Russell wrote:
> It seems so, as Al so comprehensively explained. It was binutils
> breakage. You might find something like this (note: untested!)
> preferable. Other archs may well want EXPORT_SYMBOL_AS for special
> effects anyway.
>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>
> Make sparc use the same "remove the dot" mangling as other archs, which
> depmod already understands. Avoid namespace pollution (not really a
> problem, but ugly) by using an __export_ alias: it needs to be a global
> symbol as attempts to craft an alias in the sparc_ksyms.c was rejected
> by various recent binutils versions:
ewww...
You do realize that your "remove the dot" is ppc-only? I.e. just as much
of a special case as sparc-only mapping.
Seriously, fix in depmod is considerably smaller that what you've just
posted, not to mention being conceptually simpler.
next prev parent reply other threads:[~2006-02-12 0:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-11 11:38 [PATCH] sparc32: Fix div, udiv, mul, umul, rem, urem breakage Martin Habets
2006-02-11 11:51 ` William Lee Irwin III
2006-02-11 12:15 ` Al Viro
2006-02-11 13:04 ` William Lee Irwin III
2006-02-11 23:54 ` Rusty Russell
2006-02-12 0:21 ` Al Viro [this message]
2006-02-12 1:07 ` Rusty Russell
2006-02-12 3:14 ` Al Viro
2006-02-12 10:39 ` Rusty Russell
2006-02-15 11:56 ` Martin Habets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060212002114.GS27946@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.