All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luben Tuikov <ltuikov@yahoo.com>
To: Ryan Anderson <ryan@michonline.com>, Andrew Morton <akpm@osdl.org>
Cc: junkio@cox.net, git@vger.kernel.org
Subject: Re: git-bisect problem
Date: Mon, 13 Feb 2006 02:40:36 -0800 (PST)	[thread overview]
Message-ID: <20060213104036.67433.qmail@web31811.mail.mud.yahoo.com> (raw)
In-Reply-To: <20060213101443.GD11053@mythryan2.michonline.com>

Andrew,

Here is the output:

$ git-diff-tree --pretty -p 386093ef9a6c88576d8b418bf1c8616d5e410a20
diff-tree 386093ef9a6c88576d8b418bf1c8616d5e410a20 (from ce5f8d70ba6e3d7ffcaff86b2cf91a42c27f77af)
Author: Alexey Dobriyan <adobriyan@gmail.com>
Date:   Wed Feb 1 03:04:57 2006 -0800

    [PATCH] ipw2200: fix ->eeprom[EEPROM_VERSION] check
    
    priv->eeprom is a pointer.
    
    Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
    Acked-by: Yi Zhu <yi.zhu@intel.com>
    Cc: James Ketrenos <jketreno@linux.intel.com>
    Signed-off-by: Andrew Morton <akpm@osdl.org>
    Signed-off-by: Linus Torvalds <torvalds@osdl.org>

diff --git a/drivers/net/wireless/ipw2200.c b/drivers/net/wireless/ipw2200.c
index 916b24c..14beab4 100644
--- a/drivers/net/wireless/ipw2200.c
+++ b/drivers/net/wireless/ipw2200.c
@@ -2456,7 +2456,7 @@ static void ipw_eeprom_init_sram(struct 
           copy.  Otherwise let the firmware know to perform the operation
           on it's own
         */
-       if ((priv->eeprom + EEPROM_VERSION) != 0) {
+       if (priv->eeprom[EEPROM_VERSION] != 0) {
                IPW_DEBUG_INFO("Writing EEPROM data into SRAM\n");
 
                /* write the eeprom data to sram */

   Luben

  parent reply	other threads:[~2006-02-13 10:40 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-13  8:25 git-bisect problem Andrew Morton
2006-02-13  9:11 ` Junio C Hamano
2006-02-13  9:32   ` Andrew Morton
2006-02-13  9:39     ` Ryan Anderson
2006-02-13  9:51       ` Andrew Morton
2006-02-13  9:58         ` Fernando J. Pereda
2006-02-13 10:22           ` Luben Tuikov
2006-02-13 10:23           ` Luben Tuikov
2006-02-13 12:21           ` cat-file (was Re: git-bisect problem) Joshua N Pritikin
2006-02-13 10:14         ` git-bisect problem Ryan Anderson
2006-02-13 10:25           ` Andrew Morton
2006-02-13 16:44             ` Linus Torvalds
2006-02-13 10:40           ` Luben Tuikov [this message]
2006-02-13 10:44             ` Andrew Morton
2006-02-14  0:33         ` Junio C Hamano
2006-02-13 10:08     ` Junio C Hamano
2006-02-13 10:19       ` Andrew Morton
2006-02-14  0:32         ` Junio C Hamano
2006-02-14  0:56           ` Andrew Morton
2006-02-14  1:14             ` Linus Torvalds
2006-02-14  1:15             ` Petr Baudis
2006-02-14  1:27               ` Petr Baudis
2006-02-14  1:52             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060213104036.67433.qmail@web31811.mail.mud.yahoo.com \
    --to=ltuikov@yahoo.com \
    --cc=akpm@osdl.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=ryan@michonline.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.