From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: diffstat wierdness with 'git format-patch' output Date: Mon, 13 Feb 2006 22:52:24 -0800 Message-ID: <20060214065224.GA20541@kroah.com> References: <20060214055425.GA32261@kroah.com> <20060214055648.GA592@kroah.com> <7vveviv5d1.fsf@assigned-by-dhcp.cox.net> <20060214063420.GA11851@kroah.com> <20060214064256.GA19667@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Feb 14 07:52:38 2006 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by ciao.gmane.org with esmtp (Exim 4.43) id 1F8u36-000773-Ki for gcvg-git@gmane.org; Tue, 14 Feb 2006 07:52:32 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030401AbWBNGwV (ORCPT ); Tue, 14 Feb 2006 01:52:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030420AbWBNGwV (ORCPT ); Tue, 14 Feb 2006 01:52:21 -0500 Received: from dsl093-040-174.pdx1.dsl.speakeasy.net ([66.93.40.174]:18875 "EHLO aria.kroah.org") by vger.kernel.org with ESMTP id S1030401AbWBNGwU (ORCPT ); Tue, 14 Feb 2006 01:52:20 -0500 Received: from press.kroah.org ([192.168.0.25] helo=localhost) by aria.kroah.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.54) id 1F8u2w-00025F-3b; Mon, 13 Feb 2006 22:52:22 -0800 To: Junio C Hamano Content-Disposition: inline In-Reply-To: <20060214064256.GA19667@kroah.com> User-Agent: Mutt/1.5.11 Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: On Mon, Feb 13, 2006 at 10:42:56PM -0800, Greg KH wrote: > On Mon, Feb 13, 2006 at 10:34:20PM -0800, Greg KH wrote: > > > I personally find it useful to see the trend of version of tools > > > people use on the public mailing list, and that was the primary > > > reason it is there. > > > > Why not just add a "X-Git-Version: 1.2.0" flag to the message instead? > > And here's a patch that does just that. > > ----------------- > > Subject: change git-format-patch to put the git version in the mail header > > This is more like other tools that create mail messages, and fixes an > issue of the diffstat program thinking that an extra line was removed > from the patch. > > Signed-off-by: Greg Kroah-Hartman > > diff --git a/git-format-patch.sh b/git-format-patch.sh > index e54c9e4..5f6a921 100755 > --- a/git-format-patch.sh > +++ b/git-format-patch.sh > @@ -216,6 +216,7 @@ while () { > > print "From: $author_ident\n"; > print "Date: $author_date\n"; > + print "X-Git-Version: @@GIT_VERSION@@\n"; Hm, git-send-email doesn't see this, so it doesn't get sent out if you use that tool. I can fix that to just put the version number in the message too, like it adds the "X-Mailer" field, if people think this is really worth it... thanks, greg k-h