From: christoph <hch@lst.de>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: christoph <hch@lst.de>,
akpm@osdl.org, mcao@us.ibm.com,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH] map multiple blocks at a time in mpage_readpages()
Date: Tue, 14 Feb 2006 20:27:14 +0100 [thread overview]
Message-ID: <20060214192714.GA20956@lst.de> (raw)
In-Reply-To: <1139939347.4762.18.camel@dyn9047017100.beaverton.ibm.com>
On Tue, Feb 14, 2006 at 09:49:07AM -0800, Badari Pulavarty wrote:
> Hi,
>
> I re-did the support for mpage_readpages() to map multiple blocks
> at a time (basically, get_blocks()). Instead of adding new
> get_blocks() and pass it around, I use "bh->b_size" to indicate
> how much of disk mapping we are interested in to get_block().
>
> This way no changes existing interfaces and no new routines need.
> Filesystem can choose to ignore the passed in "bh->b_size" value
> and map one block at a time (ext2, reiser3, etc..)
Hmm. Given that we only use buffer_heads for page-cache backed I/O
bh->b_size should always be set properly and this would be fine.
If we could completely get rid of ->get_blocks that be a nice cleanup
in all the fs drivers. OTOH I still wonder whether ->get_block should
use a small structure that just contains the information needed with
easy to decipher names..
next prev parent reply other threads:[~2006-02-14 19:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-14 17:49 [RFC][PATCH] map multiple blocks at a time in mpage_readpages() Badari Pulavarty
2006-02-14 19:27 ` christoph [this message]
2006-02-14 21:53 ` Badari Pulavarty
2006-02-14 22:53 ` Badari Pulavarty
2006-02-14 23:30 ` Daniel Phillips
2006-02-14 23:49 ` Badari Pulavarty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060214192714.GA20956@lst.de \
--to=hch@lst.de \
--cc=akpm@osdl.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcao@us.ibm.com \
--cc=pbadari@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.