From: Christoph Hellwig <hch@lst.de>
To: linux-pcmcia@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pcmcia: use kthread_ API
Date: Tue, 14 Feb 2006 20:45:22 +0100 [thread overview]
Message-ID: <20060214194522.GA21385@lst.de> (raw)
In-Reply-To: <20060214193713.GA9435@flint.arm.linux.org.uk>
On Tue, Feb 14, 2006 at 07:37:13PM +0000, Russell King wrote:
> On Tue, Feb 14, 2006 at 06:50:16PM +0100, Christoph Hellwig wrote:
> > Use the kthread_ API instead of opencoding lots of hairy code for kernel
> > thread creation and teardown.
> >
> > Also use wake_up_process instead of an additional per-socket waitqueue.
>
> Nack. This breaks an error path - look at what happens when we fail to
> register a socket - we set socket->thread to NULL and exit. That is
> then picked up by the "socket thread for socket %p did not start" code
> which you decided to remove.
Yes, you're right. Let's drop the patch for now.
prev parent reply other threads:[~2006-02-14 19:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-14 17:50 [PATCH] pcmcia: use kthread_ API Christoph Hellwig
2006-02-14 19:37 ` Russell King
2006-02-14 19:45 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060214194522.GA21385@lst.de \
--to=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.