From: Jean Delvare <khali@linux-fr.org>
To: Herbert Poetzl <herbert@13thfloor.at>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remove duplicate #includes
Date: Tue, 14 Feb 2006 22:03:13 +0100 [thread overview]
Message-ID: <20060214220313.1158be5b.khali@linux-fr.org> (raw)
In-Reply-To: <20060213093959.GA10496@MAIL.13thfloor.at>
Hi Herbert,
> recently I stumbled over a few files which #include the
> same .h file twice -- sometimes even in the immediately
> following line. so I thought I'd look into that to reduce
> the amount of duplicate includes in the kernel ...
> (...)
> diff -NurpP --minimal linux-2.6.16-rc2/drivers/macintosh/therm_pm72.c linux-2.6.16-rc2-mpf/drivers/macintosh/therm_pm72.c
> --- linux-2.6.16-rc2/drivers/macintosh/therm_pm72.c 2006-02-07 11:52:31 +0100
> +++ linux-2.6.16-rc2-mpf/drivers/macintosh/therm_pm72.c 2006-02-13 02:07:58 +0100
> @@ -104,7 +104,6 @@
> #include <linux/kernel.h>
> #include <linux/delay.h>
> #include <linux/sched.h>
> -#include <linux/i2c.h>
> #include <linux/slab.h>
> #include <linux/init.h>
> #include <linux/spinlock.h>
This one was already taken care of in a different patch:
http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc3/2.6.16-rc3-mm1/broken-out/macintosh-cleanup-the-use-of-i2c-headers.patch
So please exclude this part from your patch so as to avoid collisions.
Thanks,
--
Jean Delvare
next prev parent reply other threads:[~2006-02-14 21:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-13 9:39 [PATCH] remove duplicate #includes Herbert Poetzl
2006-02-13 10:26 ` Bastian Blank
2006-02-13 15:01 ` Herbert Poetzl
2006-02-14 15:50 ` Arthur Othieno
2006-02-15 9:48 ` Herbert Poetzl
2006-02-14 21:03 ` Jean Delvare [this message]
2006-02-14 21:21 ` Andrew Morton
2006-02-15 9:52 ` Herbert Poetzl
2006-02-15 10:12 ` Russell King
-- strict thread matches above, loose matches on Subject: below --
2015-07-02 21:40 [PATCH] remove duplicate includes Matteo Croce
2026-02-08 12:32 René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060214220313.1158be5b.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=akpm@osdl.org \
--cc=herbert@13thfloor.at \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.