All of lore.kernel.org
 help / color / mirror / Atom feed
From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] HT-1000 smbus
Date: Wed, 15 Feb 2006 22:38:21 +0000	[thread overview]
Message-ID: <20060215233821.5628e8ac.khali@linux-fr.org> (raw)
In-Reply-To: <43F105D6.7000500@cdi.cz>

Hi Martin,

> Patch is attached. Is it enough to post it here to be considered ?

Well the fix is quite simple so yes I'll consider it. However there are
a few things I'd like to see added before I accept the patch.

Firstly, please include a Signed-off-by line (see
Documentation/SubmittingPatches for details.)

Secondly, some minimalistic Kconfig and documentation updates would be
needed to mention the HT-1000.

Also, I do agree that the warning about SMBHSTCFG triggers in many
cases where it shouldn't and doing what it suggests then breaks things
more than it helps. We might discard the warning as long as the
documentation is clear about the module parameter which "fixes" the
problem for people who have it (a couple boards only as far as I know -
and I consider it a BIOS bug.) However, this should be made a different
patch as this isn't related to the HT-1000.

Thanks,
-- 
Jean Delvare


      parent reply	other threads:[~2006-02-15 22:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-13 22:19 [lm-sensors] HT-1000 smbus Martin Devera
2006-02-13 23:24 ` Rudolf Marek
2006-02-14  8:23 ` Martin Devera
2006-02-14  8:58 ` Rudolf Marek
2006-02-14 16:21 ` Martin Devera
2006-02-15 22:38 ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060215233821.5628e8ac.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.