All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@osdl.org>
Cc: Cliff Wickman <cpw@sgi.com>,
	linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	george anzinger <george@mvista.com>
Subject: Re: [RFC] sys_setrlimit() in 2.6.16
Date: Thu, 16 Feb 2006 10:47:31 +0100	[thread overview]
Message-ID: <20060216094731.GA32676@elte.hu> (raw)
In-Reply-To: <20060216005826.4afc87ae.akpm@osdl.org>


* Andrew Morton <akpm@osdl.org> wrote:

> This has to be considered a bug.  The spec certainly implies that a 
> limit of zero should be honoured and, probably more importantly, 
> that's how it works in 2.4.
> 
> Problem is, the code in there all assumes that an it_prof_expires of 
> zero means "it was never set", and changing that (add a yes-it-has 
> flag?) would be less than trivial.
> 
> So I think the path of least resistance here is to just convert the 
> caller's zero seconds into one second.  That in fact gives the same 
> behaviour as 2.4: you get whacked after one second or more CPU time.
> 
> (This is not a final patch - that revolting expression in 
> sys_setrlimit() needs help first).

your approach looks good to me. It doesnt make much sense anyway to have 
a task whacked right after startup ... so adding a common-sense "the 
user must have meant some really small value" thing doesnt look all that 
wrong.

Acked-by: Ingo Molnar <mingo@elte.hu>

	Ingo

      reply	other threads:[~2006-02-16  9:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-14 22:24 [RFC] sys_setrlimit() in 2.6.16 Cliff Wickman
2006-02-16  8:58 ` Andrew Morton
2006-02-16  9:47   ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060216094731.GA32676@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@osdl.org \
    --cc=cpw@sgi.com \
    --cc=george@mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.