All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Marzinski <bmarzins@redhat.com>
To: dm-devel@redhat.com
Subject: dm-multipath: failback problem.
Date: Thu, 16 Feb 2006 10:48:08 -0600	[thread overview]
Message-ID: <20060216164808.GA15044@ether.msp.redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

If the failback period is set to more that four times the polling interval,
paths will never fail back. This is because the failback_tick keeps getting
reet. The attached patch fixes this.

[-- Attachment #2: failback.patch --]
[-- Type: text/plain, Size: 569 bytes --]

diff -urpN mp-devel-clean/multipathd/main.c mp-devel-patched/multipathd/main.c
--- mp-devel-clean/multipathd/main.c	2006-02-15 15:26:13.000000000 -0600
+++ mp-devel-patched/multipathd/main.c	2006-02-15 17:48:56.000000000 -0600
@@ -1265,7 +1265,8 @@ checkerloop (void *ap)
 			pathinfo(pp, conf->hwtable, DI_PRIO);
 
 			if (need_switch_pathgroup(pp->mpp, 0)) {
-				if (pp->mpp->pgfailback > 0)
+				if (pp->mpp->pgfailback > 0 &&
+				    pp->mpp->failback_tick <= 0)
 					pp->mpp->failback_tick =
 						pp->mpp->pgfailback + 1;
 				else if (pp->mpp->pgfailback ==

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



             reply	other threads:[~2006-02-16 16:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-16 16:48 Benjamin Marzinski [this message]
2006-02-17 23:59 ` dm-multipath: failback problem Christophe Varoqui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060216164808.GA15044@ether.msp.redhat.com \
    --to=bmarzins@redhat.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.