* dm-multipath: failback problem.
@ 2006-02-16 16:48 Benjamin Marzinski
2006-02-17 23:59 ` Christophe Varoqui
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Marzinski @ 2006-02-16 16:48 UTC (permalink / raw)
To: dm-devel
[-- Attachment #1: Type: text/plain, Size: 189 bytes --]
If the failback period is set to more that four times the polling interval,
paths will never fail back. This is because the failback_tick keeps getting
reet. The attached patch fixes this.
[-- Attachment #2: failback.patch --]
[-- Type: text/plain, Size: 569 bytes --]
diff -urpN mp-devel-clean/multipathd/main.c mp-devel-patched/multipathd/main.c
--- mp-devel-clean/multipathd/main.c 2006-02-15 15:26:13.000000000 -0600
+++ mp-devel-patched/multipathd/main.c 2006-02-15 17:48:56.000000000 -0600
@@ -1265,7 +1265,8 @@ checkerloop (void *ap)
pathinfo(pp, conf->hwtable, DI_PRIO);
if (need_switch_pathgroup(pp->mpp, 0)) {
- if (pp->mpp->pgfailback > 0)
+ if (pp->mpp->pgfailback > 0 &&
+ pp->mpp->failback_tick <= 0)
pp->mpp->failback_tick =
pp->mpp->pgfailback + 1;
else if (pp->mpp->pgfailback ==
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: dm-multipath: failback problem.
2006-02-16 16:48 dm-multipath: failback problem Benjamin Marzinski
@ 2006-02-17 23:59 ` Christophe Varoqui
0 siblings, 0 replies; 2+ messages in thread
From: Christophe Varoqui @ 2006-02-17 23:59 UTC (permalink / raw)
To: device-mapper development
On jeu, 2006-02-16 at 10:48 -0600, Benjamin Marzinski wrote:
> If the failback period is set to more that four times the polling interval,
> paths will never fail back. This is because the failback_tick keeps getting
> reet. The attached patch fixes this.
> --
Correct. Applied with thanks.
Regards,
cvaroqui
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-02-17 23:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-16 16:48 dm-multipath: failback problem Benjamin Marzinski
2006-02-17 23:59 ` Christophe Varoqui
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.