From: Eric Wong <normalperson@yhbt.net>
To: Emmanuel Guerin <manu.dev@blairos.org>
Cc: git list <git@vger.kernel.org>, Junio C Hamano <junkio@cox.net>
Subject: [PATCH] git-svn: fix revision order when XML::Simple is not loaded
Date: Thu, 16 Feb 2006 11:47:51 -0800 [thread overview]
Message-ID: <20060216194751.GB4446@Muzzle> (raw)
In-Reply-To: <20060216073826.GA12055@hand.yhbt.net>
Thanks to Emmanuel Guerin for finding the bug.
Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
contrib/git-svn/git-svn | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
98de7584b4991ab9c4025e36bfbfc10eacd17b8d
diff --git a/contrib/git-svn/git-svn b/contrib/git-svn/git-svn
index 62fc14f..ddd9579 100755
--- a/contrib/git-svn/git-svn
+++ b/contrib/git-svn/git-svn
@@ -523,7 +523,7 @@ sub svn_log_raw {
# if we have an empty log message, put something there:
if (@svn_log) {
- $svn_log[0]->{msg} ||= "\n";
+ $svn_log[$#svn_log]->{msg} ||= "\n";
}
next;
}
@@ -538,7 +538,7 @@ sub svn_log_raw {
date => "$tz $Y-$m-$d $H:$M:$S",
author => $author,
msg => '' );
- unshift @svn_log, \%log_msg;
+ push @svn_log, \%log_msg;
$state = 'msg_start';
next;
}
@@ -546,7 +546,7 @@ sub svn_log_raw {
if ($state eq 'msg_start' && /^$/) {
$state = 'msg';
} elsif ($state eq 'msg') {
- $svn_log[0]->{msg} .= $_."\n";
+ $svn_log[$#svn_log]->{msg} .= $_."\n";
}
}
close $log_fh or croak $?;
--
1.2.0.gdee6
next prev parent reply other threads:[~2006-02-16 19:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <43F4A4B1.4010307@blairos.org>
[not found] ` <20060216190426.GC12055@hand.yhbt.net>
[not found] ` <43F4CF5E.1010700@blairos.org>
[not found] ` <20060216194532.GA4446@Muzzle>
2006-02-16 7:38 ` [ANNOUNCE] git-svn - bidirection operations between svn and git Eric Wong
2006-02-16 8:01 ` Junio C Hamano
2006-02-16 8:08 ` Aneesh Kumar
2006-02-16 8:19 ` Junio C Hamano
2006-02-16 8:30 ` Aneesh Kumar
2006-02-16 9:20 ` Junio C Hamano
2006-02-16 11:20 ` Aneesh Kumar
2006-02-16 11:57 ` Petr Baudis
2006-02-16 12:01 ` Aneesh Kumar
2006-02-16 8:48 ` Eric Wong
2006-02-16 13:42 ` Eduardo Pereira Habkost
2006-02-16 19:25 ` Eric Wong
2006-02-16 19:47 ` Eric Wong [this message]
2006-02-16 21:44 ` [PATCH] git-svn: fix revision order when XML::Simple is not loaded Eric Wong
2006-02-17 2:13 ` [PATCH] git-svn: ensure fetch always works chronologically Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060216194751.GB4446@Muzzle \
--to=normalperson@yhbt.net \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=manu.dev@blairos.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.