From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1F9rdN-0002Sv-3z for qemu-devel@nongnu.org; Thu, 16 Feb 2006 17:29:57 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1F9rcc-0001Fn-Kw for qemu-devel@nongnu.org; Thu, 16 Feb 2006 17:29:12 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F9rbJ-0007gj-6M for qemu-devel@nongnu.org; Thu, 16 Feb 2006 17:27:49 -0500 Received: from [66.93.172.17] (helo=nevyn.them.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1F9rgW-000700-Lw for qemu-devel@nongnu.org; Thu, 16 Feb 2006 17:33:12 -0500 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1F9rbH-0000RM-Bn for qemu-devel@nongnu.org; Thu, 16 Feb 2006 17:27:47 -0500 Date: Thu, 16 Feb 2006 17:27:47 -0500 From: Daniel Jacobowitz Subject: Re: [Qemu-devel] [PATCH] Trivial code improvement Message-ID: <20060216222747.GA1652@nevyn.them.org> References: <20060216163204.GB23684@networkno.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060216163204.GB23684@networkno.de> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Thu, Feb 16, 2006 at 04:32:04PM +0000, Thiemo Seufer wrote: > Index: cpu-exec.c > =================================================================== > RCS file: /sources/qemu/qemu/cpu-exec.c,v > retrieving revision 1.73 > diff -u -p -r1.73 cpu-exec.c > --- cpu-exec.c 8 Feb 2006 22:43:39 -0000 1.73 > +++ cpu-exec.c 16 Feb 2006 15:21:03 -0000 > @@ -549,7 +549,7 @@ int cpu_exec(CPUState *env1) > do_interrupt(env); > } > #endif > - if (env->interrupt_request & CPU_INTERRUPT_EXITTB) { > + if (interrupt_request & CPU_INTERRUPT_EXITTB) { > env->interrupt_request &= ~CPU_INTERRUPT_EXITTB; > /* ensure that no TB jump will be modified as > the program flow was changed */ Didn't we go round this recently? do_interrupt might modify env->interrupt_request - see target-arm/helper.c for instance. -- Daniel Jacobowitz CodeSourcery