All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Kropelin <akropel1@rochester.rr.com>
To: philippe.seewer@bfh.ch
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	tsbogend@alpha.franken.de
Subject: Re: [PATCH 2/2] pcnet32: PHY selection support
Date: Fri, 17 Feb 2006 13:49:38 -0500	[thread overview]
Message-ID: <20060217134938.B24429@mail.kroptech.com> (raw)
In-Reply-To: <43F5F672.9080904@bfh.ch>

Seewer Philippe wrote:
> Most AMD pcnet chips support up to 32 external PHYs. This patch
> introduces basic PHY selection/switching support, by adding two
> new module parameters:
> -maxphy: how many PHYs the card supports
> -usephy: which phy to use instead of eeprom default
> 
> Maxphy is necessary in order to check the range of usephy and may
> be overriden inside the module.

It seems a bit pointless for the range check of a user-supplied value to
be driven by another user-supplied value.

> If only maxphy is present I've implemented an algorithm which checks
> the link state on all PHYs and uses the one that has a link.

Knowing how many PHYs to scan is potentially useful, but how about
determining that at runtime? Missing PHYs should be detectable with a
timeout or similar. Too risky?

--Adam


  reply	other threads:[~2006-02-17 17:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-17 16:14 [PATCH 2/2] pcnet32: PHY selection support Seewer Philippe
2006-02-17 18:49 ` Adam Kropelin [this message]
2006-02-17 19:56   ` Seewer Philippe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060217134938.B24429@mail.kroptech.com \
    --to=akropel1@rochester.rr.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=philippe.seewer@bfh.ch \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.