All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ftp.linux.org.uk>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-kernel@vger.kernel.org, adaplas@pol.net, ralf@linux-mips.org
Subject: Re: [PATCH] add __force tag to fb_readb, etc.
Date: Fri, 17 Feb 2006 16:12:47 +0000	[thread overview]
Message-ID: <20060217161247.GN27946@ftp.linux.org.uk> (raw)
In-Reply-To: <20060218.000408.07643246.anemo@mba.ocn.ne.jp>

On Sat, Feb 18, 2006 at 12:04:08AM +0900, Atsushi Nemoto wrote:
> This patch fixes many sparse warnings on MIPS (and some other) platform.

ITYM "hides".  You've just lost anything resembling typechecking of
arguments; it might be wrong in the current form, but at least we
get a reminder of possible problems.

With __force you've lost _all_ warnings - anything goes.  NAK.  At the
very least, figure out what type should the argument be and add a
(non-force) cast to that before forcing it.

  reply	other threads:[~2006-02-17 16:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-17 15:04 [PATCH] add __force tag to fb_readb, etc Atsushi Nemoto
2006-02-17 16:12 ` Al Viro [this message]
2006-02-17 16:33   ` Atsushi Nemoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060217161247.GN27946@ftp.linux.org.uk \
    --to=viro@ftp.linux.org.uk \
    --cc=adaplas@pol.net \
    --cc=anemo@mba.ocn.ne.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.