From: Andi Kleen <ak@suse.de>
To: dan.yeisley@unisys.com
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [patch] i386 need to pass virtual address to smp_read_mpc()
Date: Fri, 17 Feb 2006 21:34:24 +0100 [thread overview]
Message-ID: <200602172134.24582.ak@suse.de> (raw)
In-Reply-To: <1140207880.2910.10.camel@localhost.localdomain>
On Friday 17 February 2006 21:24, Daniel Yeisley wrote:
> I'm seeing a kernel panic on an ES7000-600 when booting in virtual wire
> mode. The panic happens because smp_read_mpc() is passed a physical
> address, and it should be virtual. I tested the attached patch on the
> ES7000-600 and on a 2 cpu Dell box, and saw no problems on either.
Looks obviously correct. Should probably be in 2.6.16
-Andi
>
> Signed-off-by: Dan Yeisley <dan.yeisley@unisys.com>
> ---
>
> diff -Naur -p linux-2.6.16-rc1-git3-7/arch/i386/kernel/mpparse.c linux-2.6.16-rc1-git3-7-a/arch/i386/kernel/mpparse.c
> --- linux-2.6.16-rc1-git3-7/arch/i386/kernel/mpparse.c 2006-01-30 18:38:18.000000000 -0500
> +++ linux-2.6.16-rc1-git3-7-a/arch/i386/kernel/mpparse.c 2006-02-16 04:51:35.551014272 -0500
> @@ -710,7 +710,7 @@ void __init get_smp_config (void)
> * Read the physical hardware table. Anything here will
> * override the defaults.
> */
> - if (!smp_read_mpc((void *)mpf->mpf_physptr)) {
> + if (!smp_read_mpc(phys_to_virt(mpf->mpf_physptr)))
> smp_found_config = 0;
> printk(KERN_ERR "BIOS bug, MP table errors detected!...\n");
> printk(KERN_ERR "... disabling SMP support. (tell your hw vendor)\n");
>
>
>
next prev parent reply other threads:[~2006-02-17 20:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-17 20:24 [patch] i386 need to pass virtual address to smp_read_mpc() Daniel Yeisley
2006-02-17 20:34 ` Andi Kleen [this message]
2006-02-17 20:55 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602172134.24582.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=dan.yeisley@unisys.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.