From: Herbert Poetzl <herbert@13thfloor.at>
To: Andrew Morton <akpm@osdl.org>, Al Viro <viro@ftp.linux.org.uk>
Cc: Linux Kernel ML <linux-kernel@vger.kernel.org>
Subject: kjournald keeps reference to namespace
Date: Sat, 18 Feb 2006 02:35:47 +0100 [thread overview]
Message-ID: <20060218013547.GA32706@MAIL.13thfloor.at> (raw)
Hi Folks!
when creating a private namespace (CLONE_NS) and
then mounting an ext3 filesystem, a new kernel
thread (kjournald) is created, which keeps a
reference to the namespace, which after the the
process exits, remains and blocks access to the
block device, as it is still bd_claim-ed.
this leaves a private namespace behind and a
block device which cannot be opened exclusively.
unmount is not an option, as the namespace is
not longer reachable.
this behaviour seems to be there since ever,
well since namespaces and kjournald exists :)
the following 'cruel' hack 'solves' this issue
best,
Herbert
--- fs/jbd/journal.c.orig 2006-01-03 17:29:56 +0100
+++ fs/jbd/journal.c 2006-02-18 02:23:21 +0100
@@ -33,6 +33,7 @@
#include <linux/mm.h>
#include <linux/suspend.h>
#include <linux/pagemap.h>
+#include <linux/namespace.h>
#include <asm/uaccess.h>
#include <asm/page.h>
#include <linux/proc_fs.h>
@@ -116,6 +117,13 @@ static int kjournald(void *arg)
struct timer_list timer;
daemonize("kjournald");
+ {
+ struct namespace *ns = current->namespace;
+
+ current->namespace = NULL;
+ put_namespace(ns);
+ }
+
/* Set up an interval timer which can be used to trigger a
commit wakeup after the commit interval expires */
next reply other threads:[~2006-02-18 1:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-18 1:35 Herbert Poetzl [this message]
2006-02-18 1:54 ` kjournald keeps reference to namespace Andrew Morton
2006-02-18 3:30 ` Herbert Poetzl
2006-02-24 21:28 ` Paul Collins
2006-02-24 21:36 ` Andrew Morton
2006-02-24 22:01 ` Paul Collins
2006-02-18 13:36 ` Björn Steinbrink
2006-02-18 16:32 ` Björn Steinbrink
2006-02-18 17:12 ` Björn Steinbrink
2006-02-19 2:32 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060218013547.GA32706@MAIL.13thfloor.at \
--to=herbert@13thfloor.at \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.