From: Ralf Baechle <ralf@linux-mips.org>
To: Shuveb Hussain <shuveb@gmail.com>
Cc: linux-mips@linux-mips.org
Subject: Re: mem_in? and mem_out? functions
Date: Sun, 19 Feb 2006 19:53:42 +0000 [thread overview]
Message-ID: <20060219195342.GF21416@linux-mips.org> (raw)
In-Reply-To: <c24555040510150133x7d42afe6x9526b6eecc216b5f@mail.gmail.com>
On Sat, Oct 15, 2005 at 02:03:13PM +0530, Shuveb Hussain wrote:
> Hi,
> I am compiling the source from git. There are definitions of macros in
> include/asm/io.h for the following:
>
> mem_inb
> mem_outb
> mem_inl
> mem_outl
> ...
> ...
>
> The issue is that the driver :
> drivers/char/ipmi/ - have redeclared these macros as functions
> statically, in the file - ipmi_si_intf.c
>
> I do not know if this driver is used on MIPS at all, but it does get
> into the way of proper compilation. If compilation of the IPMI driver
> in any form is disabled (by default it gets compiled as a module),
> then the compilation goes on smoothly.
>
> I changed the names of these functions slightly and made other
> modifications as to compile properly and now everything is OK, but I
> do not know if this is the best way to do it, though it works for me
> now.
>
> What is the best solution for this issue?
This has now been fixed by commit 290f10ae4230ef06b71e57673101b7e70c1b29a6.
Ralf
prev parent reply other threads:[~2006-02-20 10:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-15 8:33 mem_in? and mem_out? functions Shuveb Hussain
2006-02-19 19:53 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060219195342.GF21416@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=shuveb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.