mem_in? and mem_out? functions

mem_in? and mem_out? functions

[Shuveb Hussain]

Hi,
I am compiling the source from git. There are definitions of macros in
include/asm/io.h for the following:

mem_inb
mem_outb
mem_inl
mem_outl
...
...

The issue is that the driver :
drivers/char/ipmi/  - have redeclared these macros as functions
statically, in the file - ipmi_si_intf.c

I do not know if this driver is used on MIPS at all, but it does get
into the way of proper compilation. If compilation of the IPMI driver
in any form is disabled (by default it gets compiled as a module),
then the compilation goes on smoothly.

I changed the names of these functions slightly and made other
modifications as to compile properly and now everything is OK, but I
do not know if this is the best way to do it, though it works for me
now.

What is the best solution for this issue?

--shuveb

Re: mem_in? and mem_out? functions

[Ralf Baechle]

On Sat, Oct 15, 2005 at 02:03:13PM +0530, Shuveb Hussain wrote:

> Hi,
> I am compiling the source from git. There are definitions of macros in
> include/asm/io.h for the following:
> 
> mem_inb
> mem_outb
> mem_inl
> mem_outl
> ...
> ...
> 
> The issue is that the driver :
> drivers/char/ipmi/  - have redeclared these macros as functions
> statically, in the file - ipmi_si_intf.c
> 
> I do not know if this driver is used on MIPS at all, but it does get
> into the way of proper compilation. If compilation of the IPMI driver
> in any form is disabled (by default it gets compiled as a module),
> then the compilation goes on smoothly.
> 
> I changed the names of these functions slightly and made other
> modifications as to compile properly and now everything is OK, but I
> do not know if this is the best way to do it, though it works for me
> now.
> 
> What is the best solution for this issue?

This has now been fixed by commit 290f10ae4230ef06b71e57673101b7e70c1b29a6.

  Ralf