From: Matthew Garrett <mjg59@srcf.ucam.org>
To: jayakumar.acpi@gmail.com
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.15.3 1/1] ACPI: Atlas ACPI driver
Date: Mon, 20 Feb 2006 10:26:39 +0000 [thread overview]
Message-ID: <20060220102639.GA4342@srcf.ucam.org> (raw)
In-Reply-To: <200602200213.k1K2DrDW013988@ns1.clipsalportal.com>
On Mon, Feb 20, 2006 at 10:13:53AM +0800, jayakumar.acpi@gmail.com wrote:
> + /* setup proc entry to set and get lcd brightness */
> + proc = create_proc_read_entry("lcd", S_IFREG | S_IRUGO | S_IWUSR,
> + atlas_proc_dir, atlas_read_proc_lcd, atlas_dev);
For basic sanity, could this please be a standard backlight driver
rather than sticking yet another backlight control under yet another
directory in /proc? It makes userspace much, much easier.
drivers/video/backlight/corgi_bl.c is an example, but also see my posts
to acpi-devel with patches that add it to existing acpi drivers.
> + return atlas_acpi_button_add(device);
What buttons does the hardware have? Would it make more sense for it to
be an input driver rather than (or as well as) just dropping stuff in
acpi/events?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2006-02-20 10:27 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-20 2:13 [PATCH 2.6.15.3 1/1] ACPI: Atlas ACPI driver jayakumar.acpi
2006-02-20 10:26 ` Matthew Garrett [this message]
2006-02-20 10:49 ` Jaya Kumar
2006-02-20 11:01 ` Matthew Garrett
2006-02-20 11:17 ` Henrik Brix Andersen
2006-02-21 0:02 ` Matthew Garrett
2006-02-20 11:25 ` Jaya Kumar
2006-02-20 11:28 ` Matthew Garrett
-- strict thread matches above, loose matches on Subject: below --
2006-02-20 8:26 Yu, Luming
2006-02-20 8:26 ` Yu, Luming
2006-02-20 8:37 ` Jaya Kumar
[not found] <AcY1+QTZumb9d6e3RHms9ocp4LswwgAtmORQ>
2006-02-21 6:34 ` Yu, Luming
2006-02-21 6:34 ` Yu, Luming
2006-03-03 8:16 ` Jaya Kumar
2006-03-06 13:50 Yu, Luming
2006-03-06 13:50 ` Yu, Luming
2006-03-07 1:50 ` Jaya Kumar
2006-03-07 8:52 Yu, Luming
2006-03-07 8:52 ` Yu, Luming
2006-03-07 16:09 ` Jaya Kumar
2006-03-08 6:17 Yu, Luming
2006-03-08 6:17 ` Yu, Luming
2006-03-08 7:11 ` Jaya Kumar
2006-03-08 7:44 Yu, Luming
2006-03-08 7:44 ` Yu, Luming
2006-03-08 8:53 ` Jaya Kumar
2006-03-13 6:38 ` Jaya Kumar
2006-03-13 13:16 Yu, Luming
2006-03-13 13:16 ` Yu, Luming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060220102639.GA4342@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=jayakumar.acpi@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.