All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Horton <pdh@colonel-panic.org>
To: Martin Michlmayr <tbm@cyrius.com>
Subject: Re: Diff between Linus' and linux-mips git: tulip
Date: Mon, 20 Feb 2006 23:03:49 +0000	[thread overview]
Message-ID: <20060220230349.GB1122@colonel-panic.org> (raw)
In-Reply-To: <20060220001907.GC17967@deprecation.cyrius.com>

On Mon, Feb 20, 2006 at 12:19:07AM +0000, Martin Michlmayr wrote:
> Anyone know what this change is good for?
> 
> 
> --- linux-2.6.16-rc4/drivers/net/tulip/tulip_core.c	2006-02-19 20:09:12.000000000 +0000
> +++ mips-2.6.16-rc4/drivers/net/tulip/tulip_core.c	2006-02-19 20:15:27.000000000 +0000
> @@ -1495,8 +1495,8 @@
>                 if ((pdev->bus->number == 0) && (PCI_SLOT(pdev->devfn) == 4)) {
>                         /* DDB5477 MAC address in first EEPROM locations. */
>                         sa_offset = 0;
> -                       /* No media table either */
> -                       tp->flags &= ~HAS_MEDIA_TABLE;
> +		       /* Ensure our media table fixup get's applied */
> +		       memcpy(ee_data + 16, ee_data, 8);
>                 }
>  #endif
>  #ifdef CONFIG_MIPS_COBALT
> 

Didn't the memcpy() used to be inside the CONFIG_MIPS_COBALT section ?

Looking at tulip/eeprom.c I can't work out why it was ever there though
...

P.

  reply	other threads:[~2006-02-24  1:40 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-19 23:43 Diff between Linus' and linux-mips git: drivers! Martin Michlmayr
2006-02-19 23:47 ` Diff between Linus' and linux-mips git: trivial changes Martin Michlmayr
2006-02-20 13:33   ` Maciej W. Rozycki
2006-02-20 14:11     ` Ralf Baechle
2006-02-20 14:16     ` Martin Michlmayr
2006-02-20 14:16     ` Martin Michlmayr
2006-02-20 14:18     ` Martin Michlmayr
2006-02-20 14:28     ` Martin Michlmayr
2006-02-20 16:58       ` Maciej W. Rozycki
2006-02-20 18:09         ` Martin Michlmayr
2006-02-27 22:34   ` Martin Michlmayr
2006-02-28 21:10     ` Jordan Crouse
2006-02-20  0:01 ` Diff between Linus' and linux-mips git: small changes Martin Michlmayr
2006-02-20  0:11   ` Diff between Linus' and linux-mips git: VR4181 Martin Michlmayr
2006-02-20  0:31     ` Diff between Linus' and linux-mips git: elf.h Martin Michlmayr
2006-02-20 11:34       ` Ralf Baechle
2006-04-07 17:19         ` Martin Michlmayr
2006-04-07 17:47           ` Kevin D. Kissell
2006-04-07 17:47             ` Kevin D. Kissell
2006-04-07 22:21             ` Ralf Baechle
2006-04-10 12:27               ` Thiemo Seufer
2006-04-10 15:43                 ` Ralf Baechle
2006-02-20  1:07     ` Diff between Linus' and linux-mips git: VR4181 Yoichi Yuasa
2006-02-20  1:21       ` Martin Michlmayr
2006-02-20  1:32         ` Yoichi Yuasa
2006-02-20  1:41           ` Martin Michlmayr
2006-02-20  1:50             ` Yoichi Yuasa
2006-02-20  0:17   ` Diff between Linus' and linux-mips git: declance Martin Michlmayr
2006-02-20 14:22     ` Martin Michlmayr
2006-02-20 17:02       ` Maciej W. Rozycki
2006-02-20  0:19   ` Diff between Linus' and linux-mips git: tulip Martin Michlmayr
2006-02-20 23:03     ` Peter Horton [this message]
2006-02-24  1:13       ` Martin Michlmayr
2006-02-24  1:49         ` Martin Michlmayr
2006-02-27 18:12           ` Ralf Baechle
2006-03-01 21:53         ` Peter Horton
2006-02-27 19:07   ` Diff between Linus' and linux-mips git: small changes Martin Michlmayr
2006-02-28 20:22     ` Dmitry Torokhov
2006-02-20  0:34 ` Diff between Linus' and linux-mips git: drivers! Martin Michlmayr
2006-02-27 19:10   ` Martin Michlmayr
2006-02-28  4:47     ` Yoichi Yuasa
2006-02-28  9:51       ` Martin Michlmayr
2006-02-20 15:27 ` Jordan Crouse
2006-02-20 15:27   ` Martin Michlmayr
2006-02-20 15:52   ` Christoph Hellwig
2006-02-20 16:46   ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060220230349.GB1122@colonel-panic.org \
    --to=pdh@colonel-panic.org \
    --cc=tbm@cyrius.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.