From: Christoph Hellwig <hch@infradead.org>
To: Mark Maule <maule@sgi.com>
Cc: akpm@osdl.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] altix: export sn_pcidev_info_get
Date: Tue, 21 Feb 2006 10:36:33 +0000 [thread overview]
Message-ID: <20060221103633.GA19349@infradead.org> (raw)
In-Reply-To: <20060221024710.GB30226@sgi.com>
On Mon, Feb 20, 2006 at 08:47:10PM -0600, Mark Maule wrote:
> On Mon, Feb 20, 2006 at 08:17:14PM +0000, Christoph Hellwig wrote:
> > On Tue, Feb 14, 2006 at 10:23:37AM -0600, Mark Maule wrote:
> > > Export sn_pcidev_info_get.
> >
> > Tony or Andrew please back this out again. The only reason SGI wants this is
> > to support their illegal graphics driver, and no core code uses it.
> >
> > And Mark, please stop submitting such patches.
>
> All I'm doing by exporting sn_pcidev_info_get is allowing a module to use
> the SGI SN_PCIDEV_BUSSOFT() macro which will tell a driver which piece of
> altix PCI hw its device is sitting behind (e.g. PCIIO_ASIC_TYPE_TIOCP et. al).
And that's absolutely not something a driver should care about. If you
illegal binary driver uses it it's totally broken (but then we knew that
before anyway ;-))
next prev parent reply other threads:[~2006-02-21 10:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-14 16:23 [PATCH] altix: export sn_pcidev_info_get Mark Maule
2006-02-20 20:17 ` Christoph Hellwig
2006-02-20 21:39 ` Andrew Morton
2006-02-20 21:39 ` Andrew Morton
2006-02-21 10:48 ` Christoph Hellwig
2006-02-25 11:55 ` Christoph Hellwig
2006-02-21 2:47 ` Mark Maule
2006-02-21 2:47 ` Mark Maule
2006-02-21 8:03 ` Arjan van de Ven
2006-02-21 8:03 ` Arjan van de Ven
2006-02-21 8:20 ` Christian Hildner
2006-02-21 8:20 ` Christian Hildner
2006-02-21 10:36 ` Christoph Hellwig [this message]
2006-02-21 11:23 ` Jes Sorensen
2006-02-21 11:23 ` Jes Sorensen
2006-02-25 11:55 ` Christoph Hellwig
2006-03-01 13:34 ` Jes Sorensen
2006-03-01 13:34 ` Jes Sorensen
2006-03-01 14:41 ` Luck, Tony
2006-03-01 14:41 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060221103633.GA19349@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maule@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.