From: Andrew Morton <akpm@osdl.org>
To: Hugh Dickins <hugh@veritas.com>
Cc: torvalds@osdl.org, ak@suse.de, holt@sgi.com, bcasavan@sgi.com,
cr@sap.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tmpfs: fix mount mpol nodelist parsing
Date: Tue, 21 Feb 2006 18:30:04 -0800 [thread overview]
Message-ID: <20060221183004.72ffa011.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0602212341160.5390@goblin.wat.veritas.com>
Hugh Dickins <hugh@veritas.com> wrote:
>
> Move the mpol= parsing to shmem_parse_mpol under CONFIG_NUMA, reject
> all its options as invalid if not NUMA.
That's a bit irritating, really. It means that userspace needs to be
different for NUMA kernels (or more different, which is still bad). Boot
into a non-NUMA kernel and whoops, no tmpfs and quite possibly no boot.
But last time I whined about this Albert had a list of fairly
reasonable-sounding reasons why filesystems shouldn't silently accept
not-understood options.
But in this case, we _do_ understand them. We're just not going to do
anything about them.
I just wonder if we're being as friendly as we possibly can be to admins
and distro-makers.
[ Vaguely suprised that tmpfs isn't using match_token()... ]
next prev parent reply other threads:[~2006-02-22 2:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-21 23:49 [PATCH] tmpfs: fix mount mpol nodelist parsing Hugh Dickins
2006-02-21 23:51 ` Andi Kleen
2006-02-22 2:30 ` Andrew Morton [this message]
2006-02-22 7:21 ` Hugh Dickins
2006-02-22 7:41 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060221183004.72ffa011.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@suse.de \
--cc=bcasavan@sgi.com \
--cc=cr@sap.com \
--cc=holt@sgi.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.