From: Komal Shah <komal_shah802003@yahoo.com>
To: Daniel Petrini <d.pensator@gmail.com>,
OMAP-Linux <linux-omap-open-source@linux.omap.com>
Subject: Re: [PATCH] Make H2 board file compile without irda warning
Date: Tue, 21 Feb 2006 13:28:38 -0800 (PST) [thread overview]
Message-ID: <20060221212838.67357.qmail@web32905.mail.mud.yahoo.com> (raw)
In-Reply-To: <9268368b0602210954x5b7bdd28p7b630fe83a52647b@mail.gmail.com>
--- Daniel Petrini <d.pensator@gmail.com> wrote:
> Hi,
>
> The board file for H2 is generating a warning if compiled without
> InfraRed selection.
>
> This patch changes the location where the function
> h2_transceiver_mode
> is assigned to structure h2_irda_data, thereby preventing the
> warning.
True, the warning will be generated, but I added that check considering
that transceiver_mode function will be active only if we are
successfully able to request that GPIO. So, I am _not_ sure, but it is
better to #ifdef around the h2_transceiver_mode(...) function. What do
you think?
---Komal Shah
http://komalshah.blogspot.com/
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
next prev parent reply other threads:[~2006-02-21 21:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-21 17:54 [PATCH] Make H2 board file compile without irda warning Daniel Petrini
2006-02-21 21:28 ` Komal Shah [this message]
2006-02-21 21:54 ` Komal Shah
2006-02-22 13:18 ` Daniel Petrini
2006-02-22 13:40 ` Daniel Petrini
2006-02-22 16:16 ` Komal Shah
2006-02-25 1:10 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060221212838.67357.qmail@web32905.mail.mud.yahoo.com \
--to=komal_shah802003@yahoo.com \
--cc=d.pensator@gmail.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.