From: Andrew Morton <akpm@osdl.org>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, y-goto@jp.fujitsu.com
Subject: Re: [PATCH] refine for_each_pgdat() [1/4] refine for_each_pgdat
Date: Wed, 22 Feb 2006 14:52:56 -0800 [thread overview]
Message-ID: <20060222145256.7b84f444.akpm@osdl.org> (raw)
In-Reply-To: <20060222200402.e1145286.kamezawa.hiroyu@jp.fujitsu.com>
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
>
> This patch makes for_each_pgdat() use node_online_map.
>
> Now, online nodes are managed by node_online_map. But
> for_each_pgdat() uses pgdat_link to traverse all nodes(pgdat).
> This means management structure is duplicated.
>
> I think using node_online_map for for_each_pgdat() is simple and
> sane implementation rather than pgdat_link.
We have a bit of a mess here.
for_each_pgdat() iterates over online nodes.
for_each_cpu() iterates over possible CPUs.
It's confusing and asymmetric. If you have time, it would be nice to later
remove for_each_pgdat() and for_each_cpu() from the kernel altogether, use
for_each_online_cpu(), for_each_possible_cpu(), for_each_online_node(),
for_each_possible_node().
next prev parent reply other threads:[~2006-02-22 22:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-22 11:04 [PATCH] refine for_each_pgdat() [1/4] refine for_each_pgdat KAMEZAWA Hiroyuki
2006-02-22 22:52 ` Andrew Morton [this message]
2006-02-23 0:20 ` KAMEZAWA Hiroyuki
2006-02-23 0:29 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060222145256.7b84f444.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.