From: Christoph Hellwig <hch@lst.de>
To: davem@davemloft.net, weeve@gentoo.org
Cc: linux-scsi@vger.kernel.org, sparclinux@vger.kernel.org
Subject: [PATCH] esp: fix eh locking
Date: Wed, 22 Feb 2006 16:36:15 +0100 [thread overview]
Message-ID: <20060222153615.GA23488@lst.de> (raw)
esp_reset didn't get fixed when the EH locking changed.
->eh_bus_reset_handler is now called without the host lock held.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: xfs-2.6.x/drivers/scsi/esp.c
===================================================================
--- xfs-2.6.x.orig/drivers/scsi/esp.c 2005-10-30 22:00:21.000000000 +0100
+++ xfs-2.6.x/drivers/scsi/esp.c 2006-02-22 16:34:09.000000000 +0100
@@ -2068,14 +2068,12 @@
{
struct esp *esp = (struct esp *) SCptr->device->host->hostdata;
+ spin_lock_irq(esp->ehost->host_lock);
(void) esp_do_resetbus(esp);
-
spin_unlock_irq(esp->ehost->host_lock);
wait_event(esp->reset_queue, (esp->resetting_bus == 0));
- spin_lock_irq(esp->ehost->host_lock);
-
return SUCCESS;
}
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: davem@davemloft.net, weeve@gentoo.org
Cc: linux-scsi@vger.kernel.org, sparclinux@vger.kernel.org
Subject: [PATCH] esp: fix eh locking
Date: Wed, 22 Feb 2006 15:36:15 +0000 [thread overview]
Message-ID: <20060222153615.GA23488@lst.de> (raw)
esp_reset didn't get fixed when the EH locking changed.
->eh_bus_reset_handler is now called without the host lock held.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: xfs-2.6.x/drivers/scsi/esp.c
=================================--- xfs-2.6.x.orig/drivers/scsi/esp.c 2005-10-30 22:00:21.000000000 +0100
+++ xfs-2.6.x/drivers/scsi/esp.c 2006-02-22 16:34:09.000000000 +0100
@@ -2068,14 +2068,12 @@
{
struct esp *esp = (struct esp *) SCptr->device->host->hostdata;
+ spin_lock_irq(esp->ehost->host_lock);
(void) esp_do_resetbus(esp);
-
spin_unlock_irq(esp->ehost->host_lock);
wait_event(esp->reset_queue, (esp->resetting_bus = 0));
- spin_lock_irq(esp->ehost->host_lock);
-
return SUCCESS;
}
next reply other threads:[~2006-02-22 15:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-22 15:36 Christoph Hellwig [this message]
2006-02-22 15:36 ` [PATCH] esp: fix eh locking Christoph Hellwig
2006-02-22 22:31 ` David S. Miller
2006-02-22 22:31 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060222153615.GA23488@lst.de \
--to=hch@lst.de \
--cc=davem@davemloft.net \
--cc=linux-scsi@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=weeve@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.