* [PATCH] esp: fix eh locking
@ 2006-02-22 15:36 ` Christoph Hellwig
0 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2006-02-22 15:36 UTC (permalink / raw)
To: davem, weeve; +Cc: linux-scsi, sparclinux
esp_reset didn't get fixed when the EH locking changed.
->eh_bus_reset_handler is now called without the host lock held.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: xfs-2.6.x/drivers/scsi/esp.c
===================================================================
--- xfs-2.6.x.orig/drivers/scsi/esp.c 2005-10-30 22:00:21.000000000 +0100
+++ xfs-2.6.x/drivers/scsi/esp.c 2006-02-22 16:34:09.000000000 +0100
@@ -2068,14 +2068,12 @@
{
struct esp *esp = (struct esp *) SCptr->device->host->hostdata;
+ spin_lock_irq(esp->ehost->host_lock);
(void) esp_do_resetbus(esp);
-
spin_unlock_irq(esp->ehost->host_lock);
wait_event(esp->reset_queue, (esp->resetting_bus == 0));
- spin_lock_irq(esp->ehost->host_lock);
-
return SUCCESS;
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] esp: fix eh locking
@ 2006-02-22 15:36 ` Christoph Hellwig
0 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2006-02-22 15:36 UTC (permalink / raw)
To: davem, weeve; +Cc: linux-scsi, sparclinux
esp_reset didn't get fixed when the EH locking changed.
->eh_bus_reset_handler is now called without the host lock held.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: xfs-2.6.x/drivers/scsi/esp.c
=================================--- xfs-2.6.x.orig/drivers/scsi/esp.c 2005-10-30 22:00:21.000000000 +0100
+++ xfs-2.6.x/drivers/scsi/esp.c 2006-02-22 16:34:09.000000000 +0100
@@ -2068,14 +2068,12 @@
{
struct esp *esp = (struct esp *) SCptr->device->host->hostdata;
+ spin_lock_irq(esp->ehost->host_lock);
(void) esp_do_resetbus(esp);
-
spin_unlock_irq(esp->ehost->host_lock);
wait_event(esp->reset_queue, (esp->resetting_bus = 0));
- spin_lock_irq(esp->ehost->host_lock);
-
return SUCCESS;
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] esp: fix eh locking
2006-02-22 15:36 ` Christoph Hellwig
@ 2006-02-22 22:31 ` David S. Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David S. Miller @ 2006-02-22 22:31 UTC (permalink / raw)
To: hch; +Cc: weeve, linux-scsi, sparclinux
From: Christoph Hellwig <hch@lst.de>
Date: Wed, 22 Feb 2006 16:36:15 +0100
> esp_reset didn't get fixed when the EH locking changed.
> ->eh_bus_reset_handler is now called without the host lock held.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Thanks Christoph, I'll push this fix to Linus.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] esp: fix eh locking
@ 2006-02-22 22:31 ` David S. Miller
0 siblings, 0 replies; 4+ messages in thread
From: David S. Miller @ 2006-02-22 22:31 UTC (permalink / raw)
To: hch; +Cc: weeve, linux-scsi, sparclinux
From: Christoph Hellwig <hch@lst.de>
Date: Wed, 22 Feb 2006 16:36:15 +0100
> esp_reset didn't get fixed when the EH locking changed.
> ->eh_bus_reset_handler is now called without the host lock held.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Thanks Christoph, I'll push this fix to Linus.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-02-22 22:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-22 15:36 [PATCH] esp: fix eh locking Christoph Hellwig
2006-02-22 15:36 ` Christoph Hellwig
2006-02-22 22:31 ` David S. Miller
2006-02-22 22:31 ` David S. Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.