From: Jean Delvare <khali@linux-fr.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ][Patch] fix coding style in fscpos.c
Date: Wed, 22 Feb 2006 21:02:55 +0000 [thread overview]
Message-ID: <20060222220255.927d26f8.khali@linux-fr.org> (raw)
In-Reply-To: <1140611727.7778.8.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 920 bytes --]
Hi Darren,
> Here is a simple one I noticed.
>
> The CodingStyle document says
> "Don't put multiple statements on a single line unless you have
> something to hide:"
>
> The patch below is a very simple change to convert to requisite coding
> style.
>
> Signed-off-by: Darren Jenkins <darrenrjenkins@gmail.com>
> --- linux-2.6.16-rc3/drivers/hwmon/fscpos.c.orig 2006-02-22 23:14:39.000000000 +1100
> +++ linux-2.6.16-rc3/drivers/hwmon/fscpos.c 2006-02-22 23:22:37.000000000 +1100
> @@ -229,8 +229,10 @@ static ssize_t set_pwm(struct i2c_client
> unsigned long v = simple_strtoul(buf, NULL, 10);
>
> /* Range: 0..255 */
> - if (v < 0) v = 0;
> - if (v > 255) v = 255;
> + if (v < 0)
> + v = 0;
> + if (v > 255)
> + v = 255;
>
> down(&data->update_lock);
> data->pwm[nr - 1] = v;
>
Not worth the effort IMHO. The original code is pretty readable as it
is so I wouldn't change it.
--
Jean Delvare
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2006-02-22 21:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-22 12:35 [KJ][Patch] fix coding style in fscpos.c Darren Jenkins\
2006-02-22 21:02 ` Jean Delvare [this message]
2006-02-22 23:12 ` Adrian Bunk
2006-02-23 8:57 ` Jean Delvare
2006-02-23 17:45 ` Greg KH
2006-02-23 17:58 ` Randy.Dunlap
2006-02-23 18:06 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060222220255.927d26f8.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.