Re: [KJ][Patch] fix coding style in fscpos.c

[Adrian Bunk <bunk@stusta.de>]

[-- Attachment #1: Type: text/plain, Size: 1554 bytes --]

On Wed, Feb 22, 2006 at 10:02:55PM +0100, Jean Delvare wrote:
> Hi Darren,
> 
> > Here is a simple one I noticed.
> > 
> > The CodingStyle document says 
> > "Don't put multiple statements on a single line unless you have
> > something to hide:"
> > 
> > The patch below is a very simple change to convert to requisite coding
> > style.
> > 
> > Signed-off-by: Darren Jenkins <darrenrjenkins@gmail.com>
> > --- linux-2.6.16-rc3/drivers/hwmon/fscpos.c.orig	2006-02-22 23:14:39.000000000 +1100
> > +++ linux-2.6.16-rc3/drivers/hwmon/fscpos.c	2006-02-22 23:22:37.000000000 +1100
> > @@ -229,8 +229,10 @@ static ssize_t set_pwm(struct i2c_client
> >  	unsigned long v = simple_strtoul(buf, NULL, 10);
> >  
> >  	/* Range: 0..255 */
> > -	if (v < 0) v = 0;
> > -	if (v > 255) v = 255;
> > +	if (v < 0) 
> > +		v = 0;
> > +	if (v > 255) 
> > +		v = 255;
> >  
> >  	down(&data->update_lock);
> >  	data->pwm[nr - 1] = v;
> > 
> 
> Not worth the effort IMHO. The original code is pretty readable as it
> is so I wouldn't change it.

It's against the kernel coding style.

There many several cases with several ways to express something pretty 
readable (opening braces being an religious example), but the goal is
to stick with one way to express something throughout the whole kernel.

> Jean Delvare

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors