All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Rojhalat Ibrahim <imr@rtschenk.de>
Cc: linux-mips@linux-mips.org
Subject: Re: [RFC] SMP initialization order fixes.
Date: Thu, 23 Feb 2006 11:55:27 +0000	[thread overview]
Message-ID: <20060223115527.GA6272@linux-mips.org> (raw)
In-Reply-To: <43FD85C8.5040801@rtschenk.de>

On Thu, Feb 23, 2006 at 10:52:08AM +0100, Rojhalat Ibrahim wrote:

> Works for me with a little fix. You need to set phys_cpu_present_map
> in yosemite/smp.c. Therefore the following two lines in the patch
> are unnecessary.
> 
> > -		cpu_set(i, phys_cpu_present_map);
> > +		cpu_set(i, cpu_present_map);

In include/asm-mips/smp.h we have the define:

  #define cpu_possible_map        phys_cpu_present_map

I meant to get rid of direct references to phys_cpu_present_map so really
should have done this:

> > -		cpu_set(i, phys_cpu_present_map);
> > +		cpu_set(i, cpu_possible_map);

Anyway, I dropped this for now and will commit the patch.

Thanks for testing & fix.

  Ralf

  reply	other threads:[~2006-02-23 11:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-22 19:09 [RFC] SMP initialization order fixes Ralf Baechle
2006-02-22 21:41 ` Stuart Anderson
2006-02-23 11:31   ` Ralf Baechle
2006-02-24  0:56     ` Stuart Anderson
2006-02-24  1:42   ` Martin Michlmayr
2006-02-24  1:42     ` Martin Michlmayr
2006-02-28 20:26     ` Martin Michlmayr
2006-02-23  9:52 ` Rojhalat Ibrahim
2006-02-23 11:55   ` Ralf Baechle [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-02-24 18:12 Mark E Mason
2006-02-24 19:43 Mark E Mason
2006-02-24 20:02 ` Stuart Anderson
2006-02-24 20:44 Mark E Mason
2006-02-25 15:28 ` Stuart Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060223115527.GA6272@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=imr@rtschenk.de \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.