From: Benjamin LaHaise <bcrl@kvack.org>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>, Nathan Scott <nathans@sgi.com>,
christoph <hch@lst.de>,
mcao@us.ibm.com, lkml <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] change b_size to size_t
Date: Thu, 23 Feb 2006 11:32:04 -0500 [thread overview]
Message-ID: <20060223163204.GA27682@kvack.org> (raw)
In-Reply-To: <1140712093.22756.106.camel@dyn9047017100.beaverton.ibm.com>
On Thu, Feb 23, 2006 at 08:28:12AM -0800, Badari Pulavarty wrote:
> Here is the updated version of the patch, which changes
> buffer_head.b_size to size_t to support mapping large
> amount of disk blocks (for large IOs).
Your patch doesn't seem to be inline, so I can't quote it. Several
problems: on 64 bit platforms you introduced 4 bytes of padding into
buffer_head. atomic_t only takes up 4 byte, while size_t is 8 byte
aligned. This is a waste of memory, imo, seeing as the vast majority
of systems out there will not be doing 4GB+ ios any time soon.
Also, the cast to unsigned long long for size_t is pretty atrocious.
Cast to unsigned long if anything, as size_t is unsigned long on all
platforms linux runs on.
-ben
--
"Ladies and gentlemen, I'm sorry to interrupt, but the police are here
and they've asked us to stop the party." Don't Email: <dont@kvack.org>.
next prev parent reply other threads:[~2006-02-23 16:37 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-20 21:21 [PATCH 0/3] map multiple blocks in get_block() and mpage_readpages() Badari Pulavarty
2006-02-20 21:23 ` [PATCH 1/3] pass b_size to ->get_block() Badari Pulavarty
2006-02-20 21:23 ` [PATCH 2/3] map multiple blocks for mpage_readpages() Badari Pulavarty
2006-02-23 3:29 ` Suparna Bhattacharya
2006-02-23 22:18 ` Badari Pulavarty
2006-02-20 21:24 ` [PATCH 3/3] remove ->get_blocks() support Badari Pulavarty
2006-02-20 21:59 ` [PATCH 0/3] map multiple blocks in get_block() and mpage_readpages() Nathan Scott
2006-02-20 23:06 ` Badari Pulavarty
2006-02-20 23:16 ` Nathan Scott
2006-02-21 2:41 ` Jeremy Higdon
2006-02-21 16:03 ` Badari Pulavarty
2006-02-21 21:39 ` Nathan Scott
2006-02-22 15:12 ` christoph
2006-02-22 16:58 ` Badari Pulavarty
2006-02-22 16:59 ` christoph
2006-02-23 1:40 ` Nathan Scott
2006-02-23 1:59 ` Andrew Morton
2006-02-23 16:28 ` [PATCH] change b_size to size_t Badari Pulavarty
2006-02-23 16:32 ` Benjamin LaHaise [this message]
2006-02-23 17:20 ` Badari Pulavarty
2006-02-23 17:28 ` Badari Pulavarty
2006-02-23 17:29 ` Benjamin LaHaise
2006-02-23 18:46 ` Badari Pulavarty
2006-02-23 17:40 ` Badari Pulavarty
2006-02-23 16:40 ` Dave Kleikamp
2006-02-22 17:23 ` [PATCH 0/3] map multiple blocks in get_block() and mpage_readpages() Peter Staubach
2006-02-22 18:37 ` Dave Kleikamp
2006-02-22 19:00 ` Badari Pulavarty
2006-02-24 17:19 ` Badari Pulavarty
2006-03-06 10:03 ` Suparna Bhattacharya
2006-03-06 22:39 ` Nathan Scott
2006-03-07 9:00 ` Badari Pulavarty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060223163204.GA27682@kvack.org \
--to=bcrl@kvack.org \
--cc=akpm@osdl.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcao@us.ibm.com \
--cc=nathans@sgi.com \
--cc=pbadari@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.