All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>,
	linux-kernel@vger.kernel.org, Esben Nielsen <simlo@phys.au.dk>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: 2.6.15-rt17
Date: Fri, 24 Feb 2006 07:38:22 +0100	[thread overview]
Message-ID: <20060224063822.GC1431@elte.hu> (raw)
In-Reply-To: <Pine.LNX.4.58.0602220715460.4164@gandalf.stny.rr.com>


* Steven Rostedt <rostedt@goodmis.org> wrote:

> +	printk("| This is not a BUG\n");
> +	printk("| turn off CONFIG_DEBUG_STACK_OVERFLOW if you don't want this\n");

i added the patch below - we want to know about too high stack 
footprints.

	Ingo

Index: linux-rt.q/kernel/latency.c
===================================================================
--- linux-rt.q.orig/kernel/latency.c
+++ linux-rt.q/kernel/latency.c
@@ -414,10 +414,17 @@ static void show_stackframe(void)
 
 static notrace void __print_worst_stack(void)
 {
+	unsigned long fill_ratio;
 	printk("----------------------------->\n");
-	printk("| new stack-footprint maximum: %s/%d, %ld bytes (out of %ld bytes).\n",
+	printk("| new stack fill maximum: %s/%d, %ld bytes (out of %ld bytes).\n",
 		worst_stack_comm, worst_stack_pid,
 		MAX_STACK-worst_stack_left, (long)MAX_STACK);
+	fill_ratio = (MAX_STACK-worst_stack_left)*100/(long)MAX_STACK;
+	printk("| Stack fill ratio: %02ld%%", fill_ratio);
+	if (fill_ratio >= 90)
+		printk(" - BUG: that's quite high, please report this!\n");
+	else
+		printk(" - that's still OK, no need to report this.\n");
 	printk("------------|\n");
 
 	show_stackframe();

  parent reply	other threads:[~2006-02-24  6:39 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-21 15:55 2.6.15-rt17 Ingo Molnar
2006-02-21 16:11 ` 2.6.15-rt17 K.R. Foley
2006-02-21 16:21 ` 2.6.15-rt17 K.R. Foley
2006-02-22  7:51   ` 2.6.15-rt17 Ingo Molnar
2006-02-21 17:16 ` 2.6.15-rt17 Michal Piotrowski
2006-02-21 18:53   ` 2.6.15-rt17 Michal Piotrowski
2006-02-21 20:37     ` 2.6.15-rt17 Thomas Gleixner
2006-02-21 21:15       ` 2.6.15-rt17 Michal Piotrowski
2006-02-22 12:22   ` 2.6.15-rt17 Steven Rostedt
2006-02-22 13:47     ` 2.6.15-rt17 Michal Piotrowski
2006-02-24  6:38     ` Ingo Molnar [this message]
2006-02-24  7:09       ` 2.6.15-rt17 Steven Rostedt
2006-02-21 17:23 ` 2.6.15-rt17 Timothy R. Chavez
2006-02-21 18:24 ` 2.6.15-rt17 Daniel Walker
2006-02-21 18:46   ` 2.6.15-rt17 Thomas Gleixner
2006-02-22 16:50 ` 2.6.15-rt17 Esben Nielsen
2006-02-22 23:17   ` 2.6.15-rt17 Thomas Gleixner
2006-02-25 17:11     ` 2.6.15-rt17 Esben Nielsen
2006-02-25 17:32       ` 2.6.15-rt17 Steven Rostedt
2006-02-25 21:29         ` 2.6.15-rt17 Esben Nielsen
2006-02-25 22:25           ` 2.6.15-rt17 Esben Nielsen
2006-02-26 15:14           ` 2.6.15-rt17 Steven Rostedt
2006-02-26 22:38             ` 2.6.15-rt17 Esben Nielsen
2006-02-27  7:15               ` 2.6.15-rt17 Steven Rostedt
2006-02-23 13:49 ` 2.6.15-rt17 Bill Huey
2006-02-23 13:53   ` 2.6.15-rt17 Ingo Molnar
2006-02-23 14:05     ` 2.6.15-rt17 Bill Huey
  -- strict thread matches above, loose matches on Subject: below --
2006-02-28 19:21 2.6.15-rt17 Karsten Wiese
2006-02-28 19:43 ` 2.6.15-rt17 Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060224063822.GC1431@elte.hu \
    --to=mingo@elte.hu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.k.k.piotrowski@gmail.com \
    --cc=rostedt@goodmis.org \
    --cc=simlo@phys.au.dk \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.