All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk@arm.linux.org.uk>
To: Martin Michlmayr <tbm@cyrius.com>
Cc: linux-mips@linux-mips.org, jblache@debian.org
Subject: Re: IP22 doesn't shutdown properly
Date: Fri, 24 Feb 2006 08:31:41 +0000	[thread overview]
Message-ID: <20060224083141.GA32080@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20060224003947.GJ9704@deprecation.cyrius.com>

On Fri, Feb 24, 2006 at 12:39:47AM +0000, Martin Michlmayr wrote:
> * Russell King <rmk@arm.linux.org.uk> [2006-02-23 22:43]:
> > Looking at the ip22 driver, it seems that if shutdown() is called for
> > the console port, the driver does _nothing_.
> 
> sunzilog.c does the same, and it's based on a comment by you (quoted
> right before shutdown()).  Anyway, I don't quite understand the
> comment but maybe Ralf (or you) can write a patch.

Not quite - I didn't say "do absolutely nothing" - I did explicitly say
that something should happen on the software side, and gave the example
that the IRQ should be freed.  The intention of that comment was to
satisfy the requirement I mentioned in my previous mail in this thread.

At a guess, for the console port, you want to disable the receiver, leave
the transmitter enabled, and disable all interrupts originating from the
port.

How other drivers do it is that they do a normal shutdown in every case,
but the console code explicitly re-enables the transmitter.  I don't
understand why these two drivers can't do it the same way.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core

  parent reply	other threads:[~2006-02-24  8:24 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-17 22:58 IP22 doesn't shutdown properly Martin Michlmayr
2006-02-18  1:19 ` Kumba
2006-02-18  1:27   ` Martin Michlmayr
2006-02-18 10:36     ` Julien BLACHE
2006-02-19 16:52 ` Ralf Baechle
2006-02-20 18:12   ` Martin Michlmayr
2006-02-20 21:55     ` Ralf Baechle
2006-02-21 13:59     ` Thiemo Seufer
2006-02-21 14:23       ` Stephen P. Becker
2006-02-21 14:31         ` Thiemo Seufer
2006-02-23 21:14           ` Martin Michlmayr
2006-02-23 22:13 ` Martin Michlmayr
2006-02-23 22:43   ` Russell King
2006-02-24  0:39     ` Martin Michlmayr
2006-02-24  1:30       ` Kumba
2006-02-24  8:31       ` Russell King [this message]
2006-02-27 10:54         ` Martin Michlmayr
2006-02-24 19:05   ` Christoph Hellwig
2006-02-27 10:51     ` Martin Michlmayr
2006-02-27 10:52     ` Martin Michlmayr
2006-02-27 11:22       ` Geert Uytterhoeven
2006-02-27 11:25         ` Martin Michlmayr
2006-02-27 12:53         ` Ralf Baechle
2006-02-27 18:30         ` Martin Michlmayr
2006-03-25 17:34       ` Russell King
2006-04-07 16:21         ` Martin Michlmayr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060224083141.GA32080@flint.arm.linux.org.uk \
    --to=rmk@arm.linux.org.uk \
    --cc=jblache@debian.org \
    --cc=linux-mips@linux-mips.org \
    --cc=tbm@cyrius.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.