All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Andres Salomon <dilinger@debian.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86_64 stack trace cleanup
Date: Fri, 24 Feb 2006 11:47:02 +0100	[thread overview]
Message-ID: <200602241147.03041.ak@suse.de> (raw)
In-Reply-To: <1140777679.5073.17.camel@localhost.localdomain>

On Friday 24 February 2006 11:41, Andres Salomon wrote:
> Hi,
> 
> This patch cleans up the clutter of x86_64 stack traces, making the
> output closer to what i386 and sparc64 stack traces look like.  It uses
> print_symbol instead of resolving the symbols manually, and prints one
> frame per line instead of displaying multiple frames per line.  I left
> the other stuff in the stack dump alone; this affects only the frame
> list.
> 
> I know this has been brought up before
> (http://www.uwsg.iu.edu/hypermail/linux/kernel/0602.0/2238.html,
> although I noticed a slight problem w/ that patch, as __print_symbol
> returns void); however, for people that don't spend all their time
> looking at x86_64 backtraces, I think this consistency shouldn't be
> scoffed at.  When you switch back and forth between different archs,
> x86_64's backtrace is cluttered and confusing in comparison.

If the formatting of the oopses is  your only problem you are a 
lucky man.

The problem is your new format uses more screen estate, which is precious
after an oops because the VGA scrollback is so small.
That is why i rejected the earlier attempts at changing this.

I can offer you a deal though: if you fix VGA scrollback to have
at least 1000 lines by default we can change the oops formatting too.

-Andi

  reply	other threads:[~2006-02-24 10:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-24 10:41 [PATCH] x86_64 stack trace cleanup Andres Salomon
2006-02-24 10:47 ` Andi Kleen [this message]
2006-02-24 11:29   ` Andres Salomon
2006-02-24 12:22     ` Andi Kleen
2006-02-24 19:25       ` Alistair John Strachan
2006-02-24 19:40         ` Jesper Juhl
2006-02-24 13:35     ` Jesper Juhl
2006-02-24 12:50   ` Andrew Morton
2006-02-24 13:00     ` Andi Kleen
2006-02-24 13:13       ` Andrew Morton
2006-02-24 13:20         ` Andi Kleen
2006-02-24 15:53         ` Randy.Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200602241147.03041.ak@suse.de \
    --to=ak@suse.de \
    --cc=dilinger@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.