From: Matthew Wilcox <matthew@wil.cx>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg KH <greg@kroah.com>,
linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org
Subject: Missing piece from as659
Date: Fri, 24 Feb 2006 09:49:01 -0700 [thread overview]
Message-ID: <20060224164901.GQ28587@parisc-linux.org> (raw)
Alan, you didn't cc the pci mailing list on the original patch.
http://www.ussg.iu.edu/hypermail/linux/kernel/0602.2/2673.html
You only fix pci_get_subsys; pci_get_class has the same bug.
If it is a bug, of course. It's not clear to me whether it's permissible
to call pci_dev_put under a spinlock or not. That boils down to whether
kobject ->release methods can sleep or not. That isn't documented in
Documentation/kobject.txt and I rather think it should be.
next reply other threads:[~2006-02-24 16:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-24 16:49 Matthew Wilcox [this message]
2006-02-24 17:53 ` Missing piece from as659 Alan Stern
2006-02-24 18:04 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060224164901.GQ28587@parisc-linux.org \
--to=matthew@wil.cx \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.