From: Christoph Hellwig <hch@infradead.org>
To: Andi Kleen <ak@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>,
Arjan van de Ven <arjan@intel.linux.com>,
linux-kernel@vger.kernel.org, akpm@osdl.org, mingo@elte.hu
Subject: Re: [Patch 2/3] fast VMA recycling
Date: Fri, 24 Feb 2006 19:09:38 +0000 [thread overview]
Message-ID: <20060224190938.GA6351@infradead.org> (raw)
In-Reply-To: <200602242005.17087.ak@suse.de>
On Fri, Feb 24, 2006 at 08:05:16PM +0100, Andi Kleen wrote:
> I think voluntary preempt is generally a good idea, but we should make it optional
> for down() since it can apparently cause bad side effects (like holding
> semaphores/mutexes for too long)
>
> There would be two possible ways:
>
> have default mutex_lock()/down() do a might_sleep()
> with preemption and have a separate variant that doesn't preempt
> or have the default non preempt and a separate variant
> that does preempt.
better remove the stupid cond_resched() from might_sleep which from it's
naming already is a debug thing and add it to those places where it makes
sense.
next prev parent reply other threads:[~2006-02-24 19:09 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-23 9:17 [Patch 0/3] threaded mmap tweaks Arjan van de Ven
2006-02-23 9:29 ` [Patch 3/3] prepopulate/cache cleared pages Arjan van de Ven
2006-02-23 9:41 ` Andi Kleen
2006-02-23 12:41 ` Ingo Molnar
2006-02-23 13:06 ` Andi Kleen
2006-02-23 13:15 ` Nick Piggin
2006-02-23 13:29 ` Ingo Molnar
2006-02-24 6:36 ` Nick Piggin
2006-02-24 6:49 ` Ingo Molnar
2006-02-24 7:01 ` Nick Piggin
2006-02-24 12:33 ` Andi Kleen
2006-02-24 12:55 ` Hugh Dickins
2006-02-24 9:15 ` Arjan van de Ven
2006-02-24 9:26 ` Nick Piggin
2006-02-24 12:27 ` Andi Kleen
2006-02-24 15:31 ` Andrea Arcangeli
2006-02-25 16:48 ` Nick Piggin
2006-02-25 17:22 ` Nick Piggin
2006-02-28 22:30 ` Pavel Machek
2006-02-23 18:25 ` Paul Jackson
2006-02-23 9:30 ` [Patch 2/3] fast VMA recycling Arjan van de Ven
2006-02-23 9:42 ` Andi Kleen
2006-02-23 9:48 ` Arjan van de Ven
2006-02-23 10:05 ` Andi Kleen
2006-02-23 10:15 ` Arjan van de Ven
2006-02-23 11:00 ` Andi Kleen
2006-02-23 11:22 ` Arjan van de Ven
2006-02-23 11:57 ` Andi Kleen
2006-02-24 18:52 ` Christoph Hellwig
2006-02-24 19:05 ` Andi Kleen
2006-02-24 19:09 ` Christoph Hellwig [this message]
2006-02-23 16:37 ` Benjamin LaHaise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060224190938.GA6351@infradead.org \
--to=hch@infradead.org \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=arjan@intel.linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.