From: Jesper Juhl <jesper.juhl@gmail.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.de>,
Jesper Juhl <jesper.juhl@gmail.com>
Subject: [PATCH 01/13] don't check vfree argument for NULL in vx_pcm
Date: Fri, 24 Feb 2006 21:46:57 +0100 [thread overview]
Message-ID: <200602242146.57413.jesper.juhl@gmail.com> (raw)
It's pointless checking pointers about to be passed to vfree() for NULL.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
sound/drivers/vx/vx_pcm.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
--- linux-2.6.16-rc4-mm2-orig/sound/drivers/vx/vx_pcm.c 2006-02-18 02:09:11.000000000 +0100
+++ linux-2.6.16-rc4-mm2/sound/drivers/vx/vx_pcm.c 2006-02-24 19:50:19.000000000 +0100
@@ -98,10 +98,9 @@ static int snd_pcm_alloc_vmalloc_buffer(
static int snd_pcm_free_vmalloc_buffer(struct snd_pcm_substream *subs)
{
struct snd_pcm_runtime *runtime = subs->runtime;
- if (runtime->dma_area) {
- vfree(runtime->dma_area);
- runtime->dma_area = NULL;
- }
+
+ vfree(runtime->dma_area);
+ runtime->dma_area = NULL;
return 0;
}
reply other threads:[~2006-02-24 20:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602242146.57413.jesper.juhl@gmail.com \
--to=jesper.juhl@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.