All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesper Juhl <jesper.juhl@gmail.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, Andrew Veliath <andrewtv@usa.net>,
	Jesper Juhl <jesper.juhl@gmail.com>
Subject: [PATCH 10/13] vfree does its own NULL check, no need to be explicit in oss/msnd.c
Date: Fri, 24 Feb 2006 21:49:10 +0100	[thread overview]
Message-ID: <200602242149.10322.jesper.juhl@gmail.com> (raw)


vfree() does it's own NULL checking, no need for explicit check before
calling it.


Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---

 sound/oss/msnd.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

--- linux-2.6.16-rc4-mm2-orig/sound/oss/msnd.c	2006-01-03 04:21:10.000000000 +0100
+++ linux-2.6.16-rc4-mm2/sound/oss/msnd.c	2006-02-24 21:01:30.000000000 +0100
@@ -95,10 +95,8 @@ void msnd_fifo_init(msnd_fifo *f)
 
 void msnd_fifo_free(msnd_fifo *f)
 {
-	if (f->data) {
-		vfree(f->data);
-		f->data = NULL;
-	}
+	vfree(f->data);
+	f->data = NULL;
 }
 
 int msnd_fifo_alloc(msnd_fifo *f, size_t n)




                 reply	other threads:[~2006-02-24 20:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200602242149.10322.jesper.juhl@gmail.com \
    --to=jesper.juhl@gmail.com \
    --cc=akpm@osdl.org \
    --cc=andrewtv@usa.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.